pagy_url_for in url mode gets duplicated page param

[r-sierra]

Hey guys,
I'm trying to paginate an API, with the latest release(2.1.4)and the links generated by pagy_headers_hash are incorrect. Doing a GET request to http://localhost:3000/items.json?page=2 I expected pagy_headers_hash to return:

"Link": {
  "first":"http://localhost:3000/items?page=1",
  "prev":"http://localhost:3000/items?page=1",
  "next":"http://localhost:3000/items?page=3",
  "last":"http://localhost:3000/items?page=9"
  }

but instead got:

"Link": {
  "first":"http://localhost:3000/items?page=2?page=1",
  "prev":"http://localhost:3000/items?page=2?page=1",
  "next":"http://localhost:3000/items?page=2?page=3",
  "last":"http://localhost:3000/items?page=2?page=9"
}

After reading the code it seems that the problem is around this line:

pagy/lib/pagy/extras/headers.rb

Line 26 in 95cdf61

url_str = pagy_url_for(Frontend::MARKER, pagy, :url)

which calls:

pagy/lib/pagy/frontend.rb

Line 17 in 95cdf61

"#{request.send(path_or_url)}?#{Rack::Utils.build_nested_query(pagy_get_params(params))}#{p_vars[:anchor]}"

And request.send(:url) will return the full URL with its query string according to Rack documentation. Hence the double parameters.

Please let me know if you need any additional information.
Excellent work by the way! Awesome gem,
Thanks

[ddnexus]

@r-sierra Yes, that's a bug, and, as you find-out, it is due to an improper use of request.url.

I forgot to add tests to check the full url when I pushed the headers extra. Adding better tests exposed also another missing thing: the items extra overrides the pagy_url_for but it used the old pagy_url_for implementation, so that has been fixed as well now.

Thank you.