Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Swedish locale to sv.yml #226

Merged

Conversation

davidwessman
Copy link
Contributor

@davidwessman
Copy link
Contributor Author

I decided to rename it completely, but feel free to keep the old file for backwards compatibility if that is needed.

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #226 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          530       530           
=========================================
  Hits           530       530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133da16...774a03e. Read the comment docs.

@ddnexus
Copy link
Owner

ddnexus commented Mar 17, 2020

I think we should have a sv.yml containing the sv key and a sv-SE.yml containing sv-SE, since they are also in the official i18n gem. We used the same file/key naming for the zn-CH, zn-HK and the zn-TW.

Please, could you modify the PR accordingly?

- The Swedish locale is referred to as sv in the I18n-gem:
  https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/sv.yml
- It can also be referred to as sv-SE.
@davidwessman
Copy link
Contributor Author

I think we should have a sv.yml containing the sv key and a sv-SE.yml containing sv-SE, since they are also in the official i18n gem. We used the same file/key naming for the zn-CH, zn-HK and the zn-TW.

Please, could you modify the PR accordingly?

Done!

@ddnexus ddnexus changed the base branch from master to dev March 20, 2020 04:27
@ddnexus ddnexus changed the base branch from dev to locales-normalization March 20, 2020 05:33
@ddnexus ddnexus merged commit 6a31db6 into ddnexus:locales-normalization Mar 20, 2020
@ddnexus
Copy link
Owner

ddnexus commented Mar 20, 2020

Thank you. I will add the needed changes for pluralization and deprecation.

@ddnexus ddnexus added the merged label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants