Fix using concurrency and arg together in start #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you ran "forego start" with both arguments and a concurrency flag it
would often hang:
forego start -c hello=2 world
Secondly, in concurrency mode we didn't check if the process requested
actually existed, which could also cause forego to hang. We fix this two
bugs by unifying the argument and concurrency flag code paths. In the
process, we also extend argument mode to accept multiple processes to
launch, so we can now type:
forego start hello world
Giving us a slightly nicer interface. If you use both arguments and
concurrency flags as in the first example, this will work and even allow
you to specify the same process to launch in both lists, with the
concurrency value coming from the concurrency list.
|
@ddollar ping? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you ran "forego start" with both arguments and a concurrency flag it would often hang:
Secondly, in concurrency mode we didn't check if the process requested actually existed, which could also cause forego to hang. We fix this two bugs by unifying the argument and concurrency flag code paths. In the process, we also extend argument mode to accept multiple processes to launch, so we can now type:
Giving us a slightly nicer interface. If you use both arguments and concurrency flags as in the first example, this will work and even allow you to specify the same process to launch in both lists, with the concurrency value coming from the concurrency list.