GH-268

[padcom]

Pull request with changes implementing the ability to declare multiple PORTs. See examples. Implements #268

[padcom]

The general idea in this implementation is to stop treating PORT as some special case and include it in a copy of the engine.env (where appropriate) thus making room for additional automatic variables. The same goes for both the execution as well as exports to other systems.

[ddollar]

I'm torn on this feature. The idea seems decent, but I'm hesitant to create a new standard (PORT1, PORT2, etc) without careful consideration.

Is it possible to do the PORT math inline or in a wrapper script?

[padcom]

I know what you mean. I've been going over 2 different approaches:

1. Use inline calculation of "the next port"
2. Use PORT in conjunction with PORTx

I went with the first option to keep it backwards-compatible. Imagine a situation like this:

example: run.sh --listen PORT --serve PORT

In this case it is quite obvious we need 2 different ports.

example: run.sh --listen PORT --verify PORT

In this case the --verify might mean that we need the same port. Sure we might suggest that it makes no sense but if you take the current behavior it is exactly what would happen: the same port number would be passed on twice. That leaves with another choice:

1. Keep it backwards compatible and extend the API to allow for additional PORTx keeping the original one for backwards compatibility
2. Forget about the backwards compatibility and extend how the ports are being passed on to the application.

BTW this feature in its current form keeps the PORT variable intact meaning it is an extension rather than a completely new standard. That way we can kill two birds with one stone, in a matter of speaking.

HTH

[ddollar]

I think I'm going to err on the side of simplicity for now and say that this shouldn't be part of foreman. I really do appreciate the effort you put into this pull request.

[padcom]

I understand it is controversial to put it in the core of Foreman. Do you see any other option, like a plugin or something, that this functionality could exist in? I hate to create a fork just to include this feature as this makes maintaining it an unnecessary burden.

[ddollar]

I would solve this using binscripts.

# Procfile
example: bin/example

# bin/example
#!/bin/sh
SERVE=$(expr $PORT + 50)
run.sh --listen $PORT --serve $SERVE