New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify config filename #2

Closed
wants to merge 34 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@joelvh

joelvh commented May 14, 2012

Specify the filename to save environment variables to with the --filename option.

@tonyxiao

This comment has been minimized.

tonyxiao commented Jul 15, 2012

+1, was looking for this feature myself

@jalada

This comment has been minimized.

jalada commented Jul 27, 2012

+1 could really do with this for managing multiple .env files (e.g. .env for dev and .env_production for production)

@joelvh

This comment has been minimized.

joelvh commented Sep 12, 2012

Updated to use heroku-api

nicholasjhenry and others added some commits Sep 28, 2012

Revert "Merge pull request #4 from nicholasjhenry/master"
This reverts commit 5e5dac6, reversing
changes made to 561d592.
Upgrade to use the Heroku API
* This eliminates the various 'DEPRECATED' notices caused by using the Heroku::Client with recent versions of the Heroku gem
* Fixes issue #3
Merge pull request #7 from nicholasjhenry/readme-fix
Correct description for overwrite example
@xentek

This comment has been minimized.

xentek commented Apr 12, 2013

👍

require "heroku/command/config"
class Heroku::Command::Config
class Heroku::Command::Config < Heroku::Command::Base
# config:pull
#

This comment has been minimized.

@xentek

xentek Apr 12, 2013

You might want to update the comments here with the new --filename option

@@ -35,14 +36,20 @@ def push

This comment has been minimized.

@xentek

xentek Apr 12, 2013

You might want to update the comments here, too, with the new --filename option

@xentek

View changes

init.rb Outdated
if Heroku::VERSION >= "2.0"
# specify a specific filename to use
Heroku::Command.global_option :filename, "--filename FILENAME"

This comment has been minimized.

@xentek

xentek Apr 12, 2013

This doesn't seem to add the --filename option to the output of heroku help config:pull

@xentek

This comment has been minimized.

xentek commented May 7, 2013

Just a heads up: when using this branch, config:pull --filename doesn't seem to overwrite an existing file. To get a new config I had to remove the file manually and then re-run it.

I didn't check the file itself (probably should have), but I assumed it either didn't write to the file because it existed or appended to it.

@joelvh joelvh closed this Aug 25, 2013

@kcolton

This comment has been minimized.

kcolton commented Oct 1, 2013

Submitted a pull request which adds a very simple --env arg which lets you specify env filename for pushing and pulling and mirrors foreman's arg for nice symmetry.

#11

@Undistraction

This comment has been minimized.

Undistraction commented Oct 30, 2013

Would be great to have handling similar to Foreman and Dotenv (which it uses) So that if a production-specific env file exists; .env.staging etc, it is also loaded/pushed.

@blasterpal

This comment has been minimized.

blasterpal commented Feb 28, 2014

Is there any reason why this PR was closed or this one #11 ? @ddollar is this something you don't want in heroku-config? This feature would be arguably necessary to manage large environment configuration sets for multiple environments where source control is needed for audit purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment