Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_q is now general for all gtsummary obejcts #435

Merged
merged 1 commit into from Apr 5, 2020
Merged

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Apr 5, 2020

What changes are proposed in this pull request?
The add_q() function previously worked with tbl_summary() and tbl_uvregression(). It is now general, and can be applied to all gtsummary-type objects with a "p.value" column (including those not in the gtsummary package).

If there is an GitHub issue associated with this pull request, please provide link.
#434


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from master branch
  • NEWS.md has been updated under the heading "# gtsummary (development version)"?
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • If a new function was added, function included in pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features.
  • R CMD Check runs without errors, warnings, and notes
  • When the branch is ready to be merged into master, increment the version number using usethis::use_version(which = "dev"), run codemetar::write_codemeta(), approve, and merge the PR.

@ddsjoberg ddsjoberg merged commit 1afe30f into master Apr 5, 2020
@ddsjoberg ddsjoberg deleted the add_q_update branch April 5, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant