Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the core gtsummary code file #455

Merged
merged 2 commits into from Apr 18, 2020
Merged

updating the core gtsummary code file #455

merged 2 commits into from Apr 18, 2020

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Apr 18, 2020

What changes are proposed in this pull request?
Updated the gtsummary core code script to refer to all functions with the pkg:: so other packages that copy the file don't need to import the same functions as gtsummary in the NAMESPACE. Now they just need to depend on the same packages.

Also added some other core code that help with selecting variables to the core code script.

If there is an GitHub issue associated with this pull request, please provide link.
This closes #454


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from master branch
  • NEWS.md has been updated under the heading "# gtsummary (development version)"?
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • If a new function was added, function included in pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features.
  • R CMD Check runs without errors, warnings, and notes
  • When the branch is ready to be merged into master, increment the version number using usethis::use_version(which = "dev"), run codemetar::write_codemeta(), approve, and merge the PR.

@ddsjoberg ddsjoberg merged commit 9053f4e into master Apr 18, 2020
@ddsjoberg ddsjoberg deleted the 454_gtsummary_core branch April 18, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils-gtsummary_core.R - Refer to all non-base functions with pkg::foo()
1 participant