Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide possibility to use existing Asciidoctor Instance instead embedded variant. #147

Closed
de-jcup opened this issue Sep 17, 2018 · 9 comments
Closed

Provide possibility to use existing Asciidoctor Instance instead embedded variant. #147

de-jcup opened this issue Sep 17, 2018 · 9 comments
Assignees
@de-jcup
Milestone
1.2.0

Comments

@de-jcup
Copy link
Owner

de-jcup commented Sep 17, 2018

Wanted

There shall be the possiblity to use an existing asciidoctor installation instead of embedded variant.

This will solve #136 , #69 and also #116 .

The implementation will do a CLI call. This is for advanced users having their own working asciidoctor instance with custom templates, extensions etc.

How to implement

This will be a full CLI call as done on console .

Optional

Having no embedded JRuby the cli call could show the asciidoc outputso in a dedicated console.

Remarks

Maybe parts of EGradle CLI handling could be copied and adapted...
@de-jcup de-jcup changed the title Provide possibility to use existing Asciidoctor Instanz instead embedded variant. Provide possibility to use existing Asciidoctor Instance instead embedded variant. Sep 17, 2018
@de-jcup de-jcup mentioned this issue Sep 17, 2018
Closed
@de-jcup de-jcup added this to the 1.2.0 milestone Sep 17, 2018
@de-jcup de-jcup self-assigned this Sep 17, 2018
@de-jcup de-jcup mentioned this issue Sep 17, 2018
Closed
@de-jcup de-jcup mentioned this issue Sep 28, 2018
Closed
de-jcup added a commit that referenced this issue Oct 9, 2018
@de-jcup
Make it possible to use installed asciidoctor instance #147
744c4a7 
- removed unnecessary dependency to OSGI wrapper from editor
- implemented speciall asciidoctor implementation which
  just uses installed variant
- preferences added + defaults
de-jcup added a commit that referenced this issue Oct 9, 2018
@de-jcup
Added Asciidoctor console + preferences + improvements #147
6d08b85
@de-jcup
Copy link
Owner Author

de-jcup commented Oct 9, 2018

It's now working. Maybe some finetuning necessary, but ... it is working :-)

Users have now possibility to switch to installed version and give also additional CLI arguments. So full customizable...

image

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 9, 2018

Error output from asciidoctor instance is shown in own console:
image

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 9, 2018

Details about problems on rendering are found in error log, message contains information about command line string as well:

image

This was referenced Oct 9, 2018
Closed
Closed
@de-jcup
Copy link
Owner Author

de-jcup commented Oct 10, 2018 •
edited

Just some documentation

The next pictures shows error outputs from installed asciidoctor (just misconfigured cli arguments in preferences by adding a - unsupported-operation as cli argument)

Syntax highlighting in console for errors

image

image

Errors are marked in problem view and editor

image

image

This was referenced Oct 10, 2018
Closed
Closed
@sjaeckel
Copy link

Users have now possibility to switch to installed version and give also additional CLI arguments. So full customizable...

before you finish up working on it, would it be possible to have the option to give a path to the asciidoctor executable?
It's pretty useful to be able to use a different version than the one in the path

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 11, 2018

Okay, will implement. so reopen issue

@de-jcup de-jcup reopened this Oct 11, 2018
de-jcup added a commit that referenced this issue Oct 12, 2018
@de-jcup
Refactoring preference UI #147
f6fade8
@de-jcup
Copy link
Owner Author

de-jcup commented Oct 12, 2018

@sjaeckel Is now configurable:

image

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 12, 2018

Without path set:
image

@de-jcup
Copy link
Owner Author

de-jcup commented Oct 12, 2018

@sjaeckel just released version 1.2.0 on marketplace

@de-jcup de-jcup mentioned this issue Oct 12, 2018
Closed
de-jcup added a commit that referenced this issue Feb 5, 2019
@de-jcup
Make it possible to use installed asciidoctor instance #147
c2db472 
- removed unnecessary dependency to OSGI wrapper from editor
- implemented speciall asciidoctor implementation which
  just uses installed variant
- preferences added + defaults
de-jcup added a commit that referenced this issue Feb 5, 2019
@de-jcup
Added Asciidoctor console + preferences + improvements #147
9c45eda
de-jcup added a commit that referenced this issue Feb 5, 2019
@de-jcup
Some fine tuning, closes #147
97ae7d2 
- supporting now syntax highlighting at console
- exit code>0 output will be shown as script error in editor + problem
  view
- improved console handling + behaviour (e.g. own factory, so found in 
  console list)
de-jcup added a commit that referenced this issue Feb 5, 2019
@de-jcup
Refactoring preference UI #147
3b053cb
de-jcup added a commit that referenced this issue Feb 5, 2019
@de-jcup
Installed asciidoctor path now configurable closes #147
0b3141d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@sjaeckel @de-jcup