forked from reactstrap/reactstrap
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(Dropdown): disabled toggle (reactstrap#1571)
* fix: Dropdown disabled toggle issue This fix addresses the issue where Dropdown will be passed a `disabled` prop, yet it is still clickable. This is due to context being passed the user-defined `toggle` prop directly, rather than our defined `this.toggle` function that includes a check for `disabled`. Fixes reactstrap#1542 * fix: incorrect test assertion In the previous implementation, Dropdown wasn't properly firing the toggle function within Dropdown, so the assertion was written down wrong to compensate for that.
- Loading branch information
1 parent
ce2a9a0
commit b4edeb8
Showing
4 changed files
with
6 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters