-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConditionalField performance issue #43
Comments
I glad you liked it :) |
Awesome! Looking forward for it! |
I was just about to open an issue about this. When I add just a few ConditinoalFields Unity drags to a halt. I can bearly work on my project. I thought it had to do with the new Reorderable collections. But I just stripped out the reorderable collections and kept the ConditinoalFields and vice-versa and it is definitely the ConditionalFields the is the problem. |
Sorry for this delay guys, I've got too much work on my project recently. Hopefully I'll be able to check this issue next week |
I made a few optimizations in the latest commit Unfortunately I was unable to reproduce this performance issues so I acted blindly but I changed a lot of stuff to one-time caching so it should help. Can you please check this out and inform me if it helped or not? |
It works like a charm! Funny how it was just in time for me, as I was literally creating the PR on my project with the ConditionalFields disabled, as they were unusable. Thank you! |
Yes, that worked for me as well. Thanks! |
Super useful repo! Thank you for sharing it 👍
I have been using the ConditionalField attribute and, while very powerful, it is giving me performance issues. Even with the basic "bool" condition mode, if causes significant hiccups on the editor. This happens when when enabling/disabling the target bool OR whenever I interact in any other way with the script.
Is there anything that could be done to fix it, or at least to limit the lag/hiccup to happen only whenever we enable/disable the bool ?
Thanks!
The text was updated successfully, but these errors were encountered: