New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GH Action #123
Added GH Action #123
Conversation
0e5ea76
to
b10ae36
Compare
Great! could you please include elvis too? |
b10ae36
to
16d02a3
Compare
Done. GH Action Result: https://github.com/vkatsuba/prometheus.erl/runs/2447366977 |
I just noticed a few changed unrelated to GH actions: would be great to have them in a separate MR with short description, so I can proceed with this MR. Thanks! |
The changes is related to dialyzer warnings. The dialyzer is a part of checking in GH Actions. I can remove it but I will also need to remove dialyzer call. Just for notes. The same about running tests in container, without those changes some tests will failed - I was provide this info in description. In other words all changes in current PR is related to GH actions and for tests/checking passing in containers. |
4026b79
to
d9e31eb
Compare
@deadtrickster I was divided to separate commits with short description. As I wrote above, they all refer to the current PR. So, please take a look if this approach with dividing commits is suite for you. |
4f0b35e
to
c5c49c5
Compare
c5c49c5
to
e5b7dba
Compare
Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Added 'elvis' call to GH Actions * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore'
src/metrics/prometheus_quantile_summary.erl 307: The created fun has no local return 346: The created fun has no local return 487: Function quantile_merge/2 has no local return 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number()
In GH Action was provided error '{'EXIT',nodistribution}' Looks like 'epmd -daemon' is not working as expected for containers Start use 'erl -sname test' instead of 'epmd -daemon' will fix this issue
e5b7dba
to
84803aa
Compare
Purposes of changes:
coveralls
: used fork till merge/release add git info to coveralls send markusn/coveralls-erl#36elvis
call to GH ActionsREADME.md
: added GH Badges.travis.yml
rebar.config.script
based on GH Actionsrebar3
to.gitignore
{'EXIT',nodistribution}
dialyzer
warning:GH Action Result: https://github.com/vkatsuba/prometheus.erl/actions/runs/788619303