Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GH Action #123

Merged
merged 3 commits into from Jul 8, 2021
Merged

Conversation

vkatsuba
Copy link
Contributor

@vkatsuba vkatsuba commented Apr 27, 2021

Purposes of changes:

  • Provided base GitHub Actions
  • Added coveralls: used fork till merge/release add git info to coveralls send markusn/coveralls-erl#36
  • Added elvis call to GH Actions
  • Updated README.md: added GH Badges
  • Remove .travis.yml
  • Update rebar.config.script based on GH Actions
  • Add rebar3 to .gitignore
  • Fix error for GH Action when tests running - {'EXIT',nodistribution}
  • Fix dialyzer warning:
src/metrics/prometheus_quantile_summary.erl
 307: The created fun has no local return
 346: The created fun has no local return
 487: Function quantile_merge/2 has no local return
 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number()

GH Action Result: https://github.com/vkatsuba/prometheus.erl/actions/runs/788619303

@deadtrickster
Copy link
Owner

Great! could you please include elvis too?

@vkatsuba
Copy link
Contributor Author

vkatsuba commented Apr 27, 2021

could you please include elvis too?

Done. GH Action Result: https://github.com/vkatsuba/prometheus.erl/runs/2447366977

@deadtrickster
Copy link
Owner

I just noticed a few changed unrelated to GH actions:
src/metrics/prometheus_quantile_summary.erl
test/eunit/collectors/vm/prometheus_vm_dist_collector_tests.erl

would be great to have them in a separate MR with short description, so I can proceed with this MR. Thanks!

@vkatsuba
Copy link
Contributor Author

vkatsuba commented Apr 29, 2021

I just noticed a few changed unrelated to GH actions:

src/metrics/prometheus_quantile_summary.erl

test/eunit/collectors/vm/prometheus_vm_dist_collector_tests.erl

would be great to have them in a separate MR with short description, so I can proceed with this MR. Thanks!

The changes is related to dialyzer warnings. The dialyzer is a part of checking in GH Actions. I can remove it but I will also need to remove dialyzer call. Just for notes. The same about running tests in container, without those changes some tests will failed - I was provide this info in description. In other words all changes in current PR is related to GH actions and for tests/checking passing in containers.

@vkatsuba vkatsuba force-pushed the feature/add_gh_actions branch 2 times, most recently from 4026b79 to d9e31eb Compare April 29, 2021 08:27
@vkatsuba
Copy link
Contributor Author

@deadtrickster I was divided to separate commits with short description. As I wrote above, they all refer to the current PR. So, please take a look if this approach with dividing commits is suite for you.

Purposes of changes:
* Provided base GitHub Actions
* Added coveralls: used fork till merge/release markusn/coveralls-erl#36
* Added 'elvis' call to GH Actions
* Updated 'README': added GH Badges
* Remove '.travis.yml'
* Update 'rebar.config.script' based on GH Actions
* Add 'rebar3' to '.gitignore'
src/metrics/prometheus_quantile_summary.erl
 307: The created fun has no local return
 346: The created fun has no local return
 487: Function quantile_merge/2 has no local return
 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number()
In GH Action was provided error '{'EXIT',nodistribution}'
Looks like 'epmd -daemon' is not working as expected for containers
Start use 'erl -sname test' instead  of 'epmd -daemon' will fix this issue
@deadtrickster deadtrickster merged commit 441e38c into deadtrickster:master Jul 8, 2021
@vkatsuba vkatsuba deleted the feature/add_gh_actions branch July 8, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants