add git info to coveralls send #36

RoadRunnr · 2021-02-24T11:28:45Z

This is needed for output on GitHub Actions to correctly show up on coveralls.

might also fix #34.

vkatsuba · 2021-02-25T09:08:56Z

Could you please take a look to this changes? You see, a lot of projects where used your great plugin have some issues in GitHub actions. This changes was retested use @RoadRunnr fork and working as expected for GH actions. Many thanks for your time.

Regards,
--V

markusn · 2021-02-25T09:36:17Z

I’ll have a look sometime this week!

Both are needed on GitHub actions. Coveralls seems to be doing magic things for the other supported CIs, but for GitHub actions that magic does not work. Instead we are supposed to supply complete information. That means the git info member on the API call and a flag_name member for parallel builds.

Getting the parallel run to work on GitHub is a challenge. Add a small snippet to the README to explain how.

markusn

Thanks for your PR! I have some comments that I'd like to have addressed before merging.

markusn · 2021-02-28T19:37:20Z

src/rebar3_coveralls.erl

@@ -125,10 +125,12 @@ do_coveralls(ConvertAndSend, Get, GetLocal, MaybeSkip, Task) ->
  Report0 =
    #{service_job_id => ServiceJobId,
      service_name   => ServiceName},
+  Report1 = collect_git_info(Report0),


Make this step conditional on service being GitHub, running a shell command if the output isn't needed seems like a unnecessary.

markusn · 2021-02-28T19:38:22Z

src/rebar3_coveralls.erl

+      Report
+  end.
+
+collect_git_details(Id) ->


Please provide test cases for this function!

robertoaloi · 2021-03-01T08:20:29Z

src/rebar3_coveralls.erl

+  collect_git_branch_details(#{head => Head#{id => Id}}).
+
+collect_git_branch_details(Git) ->
+  {ok, Branch} = rebar_utils:sh("git rev-parse --abbrev-ref HEAD", []),


If this is specifically needed by GitHub actions, can't we use the GITHUB_SHA variable or any other appropriate variable as specified at https://docs.github.com/en/actions/reference/environment-variables?

Also, by looking at the Erlang LS / Coveralls interaction (https://coveralls.io/github/erlang-ls/erlang_ls) it looks like the major issue with it is that somehow coverage for Pull Requests is correctly reported, but things do not work for master/main.

If this is specifically needed by GitHub actions, can't we use the GITHUB_SHA variable or any other appropriate variable as specified at https://docs.github.com/en/actions/reference/environment-variables?

The env variables only contain the commit SHA, but we need more than that. All fields in the git key need to be filled.

Also, by looking at the Erlang LS / Coveralls interaction (https://coveralls.io/github/erlang-ls/erlang_ls) it looks like the major issue with it is that somehow coverage for Pull Requests is correctly reported, but things do not work for master/main.

Erlang LS is not using the changes from this PR, hence the wrong reporting.
Also, even when/if this PR is accepted, the GH Action in Erlang LS would need to be adjusted (see the README.md changes in the PR).

markusn · 2021-03-14T14:14:29Z

@RoadRunnr any comments on my feedback?

Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore'

Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore' * Fix error for GH Action when tests running - {'EXIT',nodistribution}

Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore' * Fix error for GH Action when tests running - {'EXIT',nodistribution} * Fix dialyzer warning: ------------------------------------------- src/metrics/prometheus_quantile_summary.erl 307: The created fun has no local return 346: The created fun has no local return 487: Function quantile_merge/2 has no local return 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number() -------------------------------------------

Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Added 'elvis' call to GH Actions * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore' * Fix error for GH Action when tests running - {'EXIT',nodistribution} * Fix dialyzer warning: ------------------------------------------- src/metrics/prometheus_quantile_summary.erl 307: The created fun has no local return 346: The created fun has no local return 487: Function quantile_merge/2 has no local return 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number() -------------------------------------------

Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Added 'elvis' call to GH Actions * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore'

markusn/coveralls-erl#36 deadtrickster/prometheus.erl#123

References: markusn/coveralls-erl#36 deadtrickster/prometheus.erl#123

Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Added 'elvis' call to GH Actions * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore'

* Added GH Action Purposes of changes: * Provided base GitHub Actions * Added coveralls: used fork till merge/release markusn/coveralls-erl#36 * Added 'elvis' call to GH Actions * Updated 'README': added GH Badges * Remove '.travis.yml' * Update 'rebar.config.script' based on GH Actions * Add 'rebar3' to '.gitignore' * Fix dialyzer warning src/metrics/prometheus_quantile_summary.erl 307: The created fun has no local return 346: The created fun has no local return 487: Function quantile_merge/2 has no local return 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number() * Fix error for GH Action when tests running In GH Action was provided error '{'EXIT',nodistribution}' Looks like 'epmd -daemon' is not working as expected for containers Start use 'erl -sname test' instead of 'epmd -daemon' will fix this issue

It contains the following patch to fix the send of Git info: markusn/coveralls-erl#36 It also fixes the send of source code.

RoadRunnr force-pushed the feature/git-info branch from e0be469 to 5b72c31 Compare February 24, 2021 11:42

RoadRunnr force-pushed the feature/git-info branch 2 times, most recently from b3003b5 to 3f27da5 Compare February 25, 2021 16:24

RoadRunnr force-pushed the feature/git-info branch from 3f27da5 to 7c97500 Compare February 25, 2021 17:48

RoadRunnr mentioned this pull request Feb 25, 2021

explain parallels end trigger on GitHub Actions #35

Closed

explain parallels end trigger on GitHub Actions

4dc8b17

Getting the parallel run to work on GitHub is a challenge. Add a small snippet to the README to explain how.

RoadRunnr force-pushed the feature/git-info branch from 7c97500 to 4dc8b17 Compare February 25, 2021 17:56

markusn requested changes Feb 28, 2021

View reviewed changes

robertoaloi reviewed Mar 1, 2021

View reviewed changes

vkatsuba mentioned this pull request Apr 27, 2021

Added GH Action deadtrickster/prometheus.erl#123

Merged

badlop added a commit to badlop/ejabberd that referenced this pull request Jun 3, 2021

Use coveralls fork to provide git information from github to coveralls

234fc70

markusn/coveralls-erl#36 deadtrickster/prometheus.erl#123

badlop added a commit to processone/ejabberd that referenced this pull request Jun 6, 2021

Workaround so coveralls website shows git commit information

2b0d724

References: markusn/coveralls-erl#36 deadtrickster/prometheus.erl#123

dumbbell added a commit to rabbitmq/khepri that referenced this pull request May 31, 2022

Rebar: Use our own fork of coveralls-erl

e2c2b66

It contains the following patch to fix the send of Git info: markusn/coveralls-erl#36 It also fixes the send of source code.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add git info to coveralls send #36

add git info to coveralls send #36

RoadRunnr commented Feb 24, 2021

vkatsuba commented Feb 25, 2021

markusn commented Feb 25, 2021

markusn left a comment

markusn Feb 28, 2021

markusn Feb 28, 2021

robertoaloi Mar 1, 2021

robertoaloi Mar 1, 2021

RoadRunnr Mar 1, 2021 •

edited

RoadRunnr Mar 1, 2021

markusn commented Mar 14, 2021

add git info to coveralls send #36

Are you sure you want to change the base?

add git info to coveralls send #36

Conversation

RoadRunnr commented Feb 24, 2021

vkatsuba commented Feb 25, 2021

markusn commented Feb 25, 2021

markusn left a comment

Choose a reason for hiding this comment

markusn Feb 28, 2021

Choose a reason for hiding this comment

markusn Feb 28, 2021

Choose a reason for hiding this comment

robertoaloi Mar 1, 2021

Choose a reason for hiding this comment

robertoaloi Mar 1, 2021

Choose a reason for hiding this comment

RoadRunnr Mar 1, 2021 • edited

Choose a reason for hiding this comment

RoadRunnr Mar 1, 2021

Choose a reason for hiding this comment

markusn commented Mar 14, 2021

RoadRunnr Mar 1, 2021 •

edited