-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistakes in removing deleted files at remote targets #54
Comments
The pull request is: #55 |
Since your PR has been merged into 1.2-dev, I've backported the fixes to v1.1-maint branch. |
Seems like deletion is now working in master. Thank you for reviewing and backporting! I have also one more fix on my other computer which is related to saving of remotely soft-deleted files. Also when I looked into code it seemed that the SOFT_DELETE=no setting was not propagated to the code executed at a remote (i.e. always soft deletion). |
Updated both branches with remote soft deletion propagation. Thanks. |
I looked at my other computer copy and noticed that you probably already fixed it yourself in master. It was needed to remove 1 in the following line to actually backup files in a root of osync`ed directory. I haven't tested v1.1-maint yet. |
Yep, found that nasty typo a couple of days ago. Thanks :) |
Hello!
I first knew about osync several days ago. I started to use it since v.1.1RC and noticed that my files are not deleted and synced back next syncs. I found where the problem is and fixed it today. I didn't know that you were working on #53 touching the same place until I tried to rebase my work against master. But now I finished it and I'd like to share it. I'll send a pull request when I figure how. :)
The text was updated successfully, but these errors were encountered: