Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistakes in removing deleted files at remote targets #54

Closed
allter opened this issue Jul 27, 2016 · 6 comments
Closed

Mistakes in removing deleted files at remote targets #54

allter opened this issue Jul 27, 2016 · 6 comments

Comments

@allter
Copy link
Contributor

allter commented Jul 27, 2016

Hello!

I first knew about osync several days ago. I started to use it since v.1.1RC and noticed that my files are not deleted and synced back next syncs. I found where the problem is and fixed it today. I didn't know that you were working on #53 touching the same place until I tried to rebase my work against master. But now I finished it and I'd like to share it. I'll send a pull request when I figure how. :)

@allter
Copy link
Contributor Author

allter commented Jul 27, 2016

The pull request is: #55

@deajan deajan added the bug label Jul 27, 2016
deajan added a commit that referenced this issue Aug 1, 2016
Fixes remote files deletion #54
@deajan
Copy link
Owner

deajan commented Aug 1, 2016

Since your PR has been merged into 1.2-dev, I've backported the fixes to v1.1-maint branch.
Feel free to test them.

@allter
Copy link
Contributor Author

allter commented Aug 2, 2016

Seems like deletion is now working in master. Thank you for reviewing and backporting! I have also one more fix on my other computer which is related to saving of remotely soft-deleted files. Also when I looked into code it seemed that the SOFT_DELETE=no setting was not propagated to the code executed at a remote (i.e. always soft deletion).

@deajan
Copy link
Owner

deajan commented Aug 2, 2016

Updated both branches with remote soft deletion propagation. Thanks.
Btw, master branch is pretty unstable to use right now, prefer v1.1-maint.
I've merged your PR so you could keep "property" of the commits, but osync.sh is rebuilt from dev/n_osync.sh which has most of your fixes ported, but not the extensive logging part as --verbose already deals with it.
I'm happy if you have other fixes, let me know.

@allter
Copy link
Contributor Author

allter commented Aug 5, 2016

I looked at my other computer copy and noticed that you probably already fixed it yourself in master. It was needed to remove 1 in the following line to actually backup files in a root of osync`ed directory.
$COMMAND_SUDO mv -f "$REPLICA_DIR$files" "$REPLICA_DIR$DELETE_DIR"1

I haven't tested v1.1-maint yet.

@deajan
Copy link
Owner

deajan commented Aug 5, 2016

Yep, found that nasty typo a couple of days ago. Thanks :)

@deajan deajan closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants