Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes isolate error in Flutter 3.3.0 #34

Merged
merged 3 commits into from Oct 31, 2022
Merged

Conversation

acoutts
Copy link
Contributor

@acoutts acoutts commented Sep 6, 2022

This is a WIP fix.

  1. We need this PR to be merged and a new version of flutter_isolate to be published: Fixing release and obfuscated build issues for flutter 3.x.x rmawatson/flutter_isolate#118
  2. Breaking change: everyone must now add the following annotation to any method they pass to IsolateHandler as the callback to execute:
@pragma('vm:entry-point')

Background: dart-lang/sdk#49181 (comment)

Will update the documentation before changing this from a draft.

@deakjahn
Copy link
Owner

deakjahn commented Sep 7, 2022

Please, help me out with the background because I can't see clearly. Will a new version come from flutter_isolate? I'd be rather unwilling to refer to a github repo instead of the normal pub.dev. Or is this just a temporary fix that will be overridden shortly? What's the expected timeline?

(.flutter-plugins-dependencies shouldn't be included, this is just a secondary issue.)

@acoutts
Copy link
Contributor Author

acoutts commented Sep 7, 2022

Yes we need to wait for a new pub release for flutter_isolate, then we can update this package. Nice spot on flutter-plugins-dependencies --- i will fix that when i update this PR once the flutter_isolate package is published.

For now Ieaving this open so others can use my git dependency as a workaround.

@deakjahn
Copy link
Owner

deakjahn commented Sep 7, 2022

OK, I'll be on the lookout.

@deakjahn
Copy link
Owner

deakjahn commented Sep 7, 2022

By the way, if we need to decorate the entry point from now on, either mention this in the README or, at least, don't let me forget to do so when we finish this operation. :-)

@deadsoul44
Copy link

I am using isolate_handler to use Firestore. It is working in debug mode but not working in release mode. Is this the reason? By the way, flutter_isolate fix was merged 7 days ago but not released.

@JamesMcIntosh
Copy link

JamesMcIntosh commented Oct 12, 2022

Hi @acoutts & @deakjahn,
Are you able to use update the PR to use the new release of flutter_isolate 2.0.3 is now available?

https://pub.dev/packages/flutter_isolate/versions/2.0.3
rmawatson/flutter_isolate#118

@acoutts acoutts changed the title Draft: Fixes isolate error in Flutter 3.3.0 Fixes isolate error in Flutter 3.3.0 Oct 13, 2022
@acoutts
Copy link
Contributor Author

acoutts commented Oct 13, 2022

Back from vacation.
Updated MR to use newly published version.
@deakjahn we are ready for a final review / merge now.

@deakjahn
Copy link
Owner

@acoutts There's this single file that says it shouldn't be included at all. Could you remove it? Then I'll merge and publish. Thanks.

@deakjahn
Copy link
Owner

@acoutts I'd be happy to go on with this. :-)

@acoutts
Copy link
Contributor Author

acoutts commented Oct 31, 2022

Done 🙌

@deakjahn deakjahn merged commit 0b58859 into deakjahn:0.2.0 Oct 31, 2022
deakjahn added a commit that referenced this pull request Oct 31, 2022
@akagupta9
Copy link

is it released?

@deakjahn
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants