-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing release and obfuscated build issues for flutter 3.x.x #118
Conversation
Note: I've had the same bug on iOS since upgrading to Flutter 3.3.0:
|
Sadly the issue is not resolved on ios with this PR -- same error printed. Note: I'm using |
Update: my issue of it not appearing to work is because even though I did a dependency override for flutter_isolate in the isolate_handler package to use your PR, my app which consumes isolate_handler still had the pub version of flutter_isolate in the lock file. I added the dependency override for flutter_isolate to my app pubspec as well, and just had to decorate the function sent to isolate_handler (which then sends it to flutter_isolate), and it's now working. |
Yes, decorations are mandatory. Additional note: sending simple classes (containing basic types) through ports does not work anymore, it actually crashes the app, so serialization / deserialization with Map is needed. |
Thanks @srmanc |
This is merged but there is no release. Could you please publish a new version on pub.dev? |
For those that are using both (A) Install the latest version of the plugins locally
(B) Update
|
@nmfisher Can we do a release on pub.dev? |
@@ -5,6 +5,7 @@ import 'package:flutter_isolate/flutter_isolate.dart'; | |||
import 'package:path_provider/path_provider.dart'; | |||
import 'package:flutter_downloader/flutter_downloader.dart'; | |||
|
|||
@pragma('vm:entry-point') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmfisher also please add that this @pragma('vm:entry-point')
is needed to the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
v2.0.3 now available on pub.dev: |
Great, thanks! |
This PR fixes release and obfuscation issues that were happending since flutter 2.8.x.
Please note that also example package was modified in order to promote the usage of
for every top level or static method in order to avoid obfuscation.
Library also failed to send List<Capability?> arguments through ports, likely because class names could not be resolved internally by dart engine. And since only basic types should be sent trough ports, List suits and works instead as well.
Please review and merge this ASAP as a lot of projects depend on this.