take over #111 to dealii-9.0 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new settings to allow native optimizations. This currently affects PETSc and deal.II (basically setting march=native).
koecher
reviewed
Apr 10, 2019
|
|
||
| if [ "${NATIVE_OPTIMIZATIONS}" = "true" ]; then | ||
| CONFOPTS="${CONFOPTS} \ | ||
| -D CMAKE_CXX_FLAGS='-march=native' |
There was a problem hiding this comment.
put a backslash to the end of this line or move up the quote from line 34 to ensure that other bash versions are fine with that
| COPTFLAGS='-O3 -march=native -mtune=native' | ||
| CXXOPTFLAGS='-O3 -march=native -mtune=native' | ||
| FOPTFLAGS='-O3 -march=native -mtune=native' | ||
| " |
There was a problem hiding this comment.
put backslashes to the end of line, as above
|
updated. |
koecher
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new settings to allow native optimizations. This currently
affects PETSc and deal.II (basically setting march=native).