-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update trilinos #92
update trilinos #92
Conversation
This doesn't work yet as some instantiations are still missing... |
Thank you Timo @tjhei |
yes, see dealii/dealii#7180 |
@Rombur I am now getting
any idea what is going on? |
@tjhei it's a bug in MueLu :( Try to add |
On 09/20/2018 03:22 PM, Bruno Turcksin wrote:
@tjhei <https://github.com/tjhei> it's a bug in MueLu :(
Would one of you file a bug with the MueLu people about this? It's easy to
work around by casting the rhs to the same type as the lhs.
|
I have open an issue trilinos/Trilinos#3480 |
that doesn't work:
MueLu reports:
|
I guess it should be |
Also take a look at trilinos/Trilinos#3480 (comment) |
I now have
but I am still getting
|
oh, and compiling with superlu_dist and complex also doesn't work.
|
@masterleinad and @Rombur : would you mind sharing the configuration you use to configure trilinos on your machines? I don't think I can make things work without your help. |
@tjhei I've never used MueLu and Tpetra at the same time. I am using Tpetra for another project and so, I have built different versions of Trilinos for each project. I don't know if it's possible to have all the options enabled when dealing with complex numbers. |
okay, that is annoying though because it will make it difficult to create a single version we can use for testing. :-( |
I am using
|
okay! Thanks @masterleinad . By disabling explicit instantiations I can at least build trilinos with and without superlu. I will test your PR next. |
I cleaned it up and can confirm that trilinos works with and without superlu and @masterleinad 's complex branch now works. |
I also have a lot of issues building Trilinos with explicit instantiations, see trilinos/Trilinos#3570 and trilinos/Trilinos#3566 So it looks like you keep those |
My configuration results in:
and |
I can build Trilinos with those extra
😢 EDIT: could be mac specific, but still scary that adding those extra |
That is |
Thanks @masterleinad |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should include the changes made by @masterleinad for trilinos 12.12 and apply the patch before building trilinos.
or wait for 12.14. I don't really want to put in and maintain patches in candi if we can avoid it. |
@tjhei waiting for 12.14 would be a clean solution. I don’t know how urgent the trilinos update is, if it would help, than it must run through without any glitches since a lot of candi users need trilinos |
So, trilinos 12.14.1 got released: https://github.com/trilinos/Trilinos/releases/tag/trilinos-release-12-14-1 Sadly, I am getting
@davydden You reported this bug in October, but it looks like it did not land in this release. |
3ee8888
to
914710d
Compare
no, it did not. trilinos/Trilinos#3574 Feel free to remind Trilinos team about this bug ;-) |
what is your workaround in spack? I can make it work by disabling ifpack2, but it doesn't look like this is what you do in spack. |
Note: this won't work with a standard MKL installation as the BLAS does not have the necessary float instantiations. It looks like we can't do something sensible with tpetra by default... |
that’s not good to hear. |
On 3/11/19 1:48 PM, Uwe Köcher wrote:
Anyhow, as long as we are happy with the old trilinos we should keep
this as the default package.
I think that's a good point. Unless there is a reason to upgrade, we
don't *have* to upgrade.
|
Agreed, but then the users of candi and the CI testers won't have access to tpetra as we don't have complex support (DEAL_II_TRILINOS_WITH_TPETRA). See dealii/dealii#7180. |
- update to 12.12 - enable complex support - require tpetra and add instantiations (fixes problems in dealii/dealii#7180 ) - disable boost (not needed and causes build to fail)
cfc58b7
to
d5365a6
Compare
I updated to the latest 12.18.1 release and did various tests:
I think this is good to go. The only caveat is that we disable Tpetra when using MKL, which is not ideal, but I don't know how to fix that. |
happy days. thank you so much @tjhei and merry christmas |
Implement TpetraWrappers::Vector dealii#7180 )