Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trilinos #92

Merged
merged 7 commits into from
Dec 24, 2019
Merged

update trilinos #92

merged 7 commits into from
Dec 24, 2019

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Sep 20, 2018

@tjhei
Copy link
Member Author

tjhei commented Sep 20, 2018

This doesn't work yet as some instantiations are still missing...

deal.II-toolchain/packages/trilinos.package Outdated Show resolved Hide resolved
@koecher
Copy link
Contributor

koecher commented Sep 20, 2018

Thank you Timo @tjhei
Are there any mayor plans in deal.II to extend the lac to Tpetra? (This would be really cool)
I'll try this during the next days, please keep us updated if it is working from your side.

@koecher koecher self-assigned this Sep 20, 2018
@koecher koecher self-requested a review September 20, 2018 20:27
@tjhei
Copy link
Member Author

tjhei commented Sep 20, 2018

Are there any mayor plans in deal.II to extend the lac to Tpetra?

yes, see dealii/dealii#7180

@tjhei
Copy link
Member Author

tjhei commented Sep 20, 2018

@Rombur I am now getting

/home/heister/Dropbox/work/deal.II/candi/candi-clean/tmp/tmp/unpack/Trilinos-trilinos-release-12-12-1/packages/muelu/src/Utils/MueLu_AlgebraicPermutationStrategy_def.hpp:381:30: error: no match for ‘operator==’ (operand types are ‘std::complex<float>’ and ‘double’)
     if(RowIdStatusArray[lik] == 0.0) {

any idea what is going on?

@Rombur
Copy link
Member

Rombur commented Sep 20, 2018

@tjhei it's a bug in MueLu :( Try to add -D MueLu_INST_COMPLEX_INT_UNSIGNED_LONG=OFF so that MueLu is not compiled with complex support.

@bangerth
Copy link
Member

bangerth commented Sep 21, 2018 via email

@Rombur
Copy link
Member

Rombur commented Sep 21, 2018

I have open an issue trilinos/Trilinos#3480

@tjhei
Copy link
Member Author

tjhei commented Sep 21, 2018

Try to add -D MueLu_INST_COMPLEX_INT_UNSIGNED_LONG=OFF

that doesn't work:

CMake Warning:
  Manually-specified variables were not used by the project:

    MueLu_INST_COMPLEX_INT_UNSIGNED_LONG

MueLu reports:

-- MueLu ETI support enabled
-- <float,   int, int>       : ON
-- <double,  int, int>       : ON
-- <double,  int, long>      : OFF
-- <double,  int, long long> : ON
-- <complex, int, int>       : ON

@Rombur
Copy link
Member

Rombur commented Sep 21, 2018

I guess it should be -D MueLu_INST_COMPLEX_INT_INT=OFF. There is also a patch here but I am not sure it can be applied to 12.12. I am trying to get the fix into 12.14 otherwise we will be stuck with this problem for another year.

@Rombur
Copy link
Member

Rombur commented Sep 21, 2018

Also take a look at trilinos/Trilinos#3480 (comment)

@tjhei
Copy link
Member Author

tjhei commented Sep 22, 2018

I now have

-- MueLu ETI support enabled
-- <float,   int, int>       : ON
-- <double,  int, int>       : ON
-- <double,  int, long>      : OFF
-- <double,  int, long long> : ON
-- <complex, int, int>       : OFF

but I am still getting

In file included from /local/candiv9-test/tmp/build/trilinos-release-12-12-1/packages/muelu/src/Utils/ExplicitInstantiation/MueLu_AlgebraicPermutationStrategy.cpp:55:0:
/local/candiv9-test/tmp/unpack/Trilinos-trilinos-release-12-12-1/packages/muelu/src/Utils/MueLu_AlgebraicPermutationStrategy_def.hpp: In instantiation of ‘void MueLu::AlgebraicPermutationStrategy<Scalar, LocalOrdinal, GlobalOrdinal
, Node>::BuildPermutation(const Teuchos::RCP<Xpetra::Matrix<Scalar, LocalOrdinal, GlobalOrdinal, Node> >&, Teuchos::RCP<const Xpetra::Map<LocalOrdinal, GlobalOrdinal, Node> >, MueLu::AlgebraicPermutationStrategy<Scalar, LocalOrdina
l, GlobalOrdinal, Node>::Level&, const FactoryBase*) const [with Scalar = std::complex<float>; LocalOrdinal = int; GlobalOrdinal = int; Node = Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial>; MueLu::AlgebraicPermutationStra
tegy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::Level = MueLu::Level; MueLu::AlgebraicPermutationStrategy<Scalar, LocalOrdinal, GlobalOrdinal, Node>::FactoryBase = MueLu::FactoryBase]’:
/local/candiv9-test/tmp/unpack/Trilinos-trilinos-release-12-12-1/packages/muelu/src/Utils/MueLu_ETI_4arg.hpp:32:3:   required from here
/local/candiv9-test/tmp/unpack/Trilinos-trilinos-release-12-12-1/packages/muelu/src/Utils/MueLu_AlgebraicPermutationStrategy_def.hpp:381:30: error: no match for ‘operator==’ (operand types are ‘std::complex<float>’ and ‘double’)
     if(RowIdStatusArray[lik] == 0.0) {

@tjhei
Copy link
Member Author

tjhei commented Sep 24, 2018

oh, and compiling with superlu_dist and complex also doesn't work.

/local/candiv9-test/tmp/unpack/Trilinos-trilinos-release-12-12-1/packages/amesos2/src/Amesos2_Superludist_def.hpp:497:76: error: no type named ‘type’ in ‘struct Amesos2::TypeMap<Amesos2::Superludist, std::complex<float> >’
         typedef Util::get_1d_copy_helper<MultiVecAdapter<Vector>,slu_type> copy_helper;

@tjhei
Copy link
Member Author

tjhei commented Sep 24, 2018

@masterleinad and @Rombur : would you mind sharing the configuration you use to configure trilinos on your machines? I don't think I can make things work without your help.

@Rombur
Copy link
Member

Rombur commented Sep 24, 2018

@tjhei I've never used MueLu and Tpetra at the same time. I am using Tpetra for another project and so, I have built different versions of Trilinos for each project. I don't know if it's possible to have all the options enabled when dealing with complex numbers.

@tjhei
Copy link
Member Author

tjhei commented Sep 24, 2018

okay, that is annoying though because it will make it difficult to create a single version we can use for testing. :-(

@masterleinad
Copy link
Member

I am using

 cmake \
         -D Trilinos_ENABLE_Amesos=ON \
         -D Trilinos_ENABLE_Epetra=ON \
         -D Trilinos_ENABLE_EpetraExt=ON \
         -D Trilinos_ENABLE_Ifpack=ON \
         -D Trilinos_ENABLE_AztecOO=ON \
         -D Trilinos_ENABLE_Sacado=ON \
         -D Trilinos_ENABLE_Teuchos=ON \
         -D Trilinos_ENABLE_MueLu=ON \
         -D Trilinos_ENABLE_ML=ON \
         -D Trilinos_ENABLE_ROL=ON \
         -D Trilinos_ENABLE_Tpetra=ON \
         -D Trilinos_ENABLE_Zoltan=ON  \
         -D Trilinos_ENABLE_Fortran=OFF \
         -D CMAKE_BUILD_TYPE=Debug \
         -D CMAKE_CXX_FLAGS="-g -O3" \
         -D CMAKE_C_FLAGS="-g -O3" \
         -D CMAKE_C_COMPILER=mpicc \
         -D CMAKE_CXX_COMPILER=mpicxx \
         -D CMAKE_FORTRAN_FLAGS="-g -O5" \
         -D Trilinos_EXTRA_LINK_FLAGS="-lgfortran" \
         -D CMAKE_VERBOSE_MAKEFILE=FALSE \
         -D Trilinos_VERBOSE_CONFIGURE=FALSE \
         -D Trilinos_ENABLE_TESTS:BOOL=ON \
         -D TPL_ENABLE_MPI=ON \
         -D MPI_BASE_DIR=/mnt/data/darndt/Sources/openmpi-clang-6 \
         -D BUILD_SHARED_LIBS=ON \
         -D CMAKE_INSTALL_PREFIX:PATH=/mnt/data/darndt/Trilinos-12.10.1-clang-6-debug \
         ..

@tjhei
Copy link
Member Author

tjhei commented Sep 24, 2018

okay! Thanks @masterleinad . By disabling explicit instantiations I can at least build trilinos with and without superlu. I will test your PR next.

@tjhei
Copy link
Member Author

tjhei commented Oct 5, 2018

I cleaned it up and can confirm that trilinos works with and without superlu and @masterleinad 's complex branch now works.

@davydden
Copy link

davydden commented Oct 6, 2018

By disabling explicit instantiations I can at least build trilinos with and without superlu

I also have a lot of issues building Trilinos with explicit instantiations, see trilinos/Trilinos#3570 and trilinos/Trilinos#3566

So it looks like you keep those Tpetra_INST_ but remove Trilinos_ENABLE_EXPLICIT_? Whereas @masterleinad does not use none of Tpetra_INST_, as far as I can tell. I am a bit confused what settings do we need in Trilinos for the upcoming TPetra support? @masterleinad @Rombur ?

@masterleinad
Copy link
Member

My configuration results in:

Tpetra_INST_COMPLEX_DOUBLE:BOOL=OFF
Tpetra_INST_COMPLEX_FLOAT:BOOL=OFF
Tpetra_INST_DD_REAL:BOOL=OFF
Tpetra_INST_DOUBLE:BOOL=ON
Tpetra_INST_FLOAT:BOOL=OFF
Tpetra_INST_FLOAT128:BOOL=OFF
Tpetra_INST_INT_INT:BOOL=ON
Tpetra_INST_INT_LONG:BOOL=OFF
Tpetra_INST_INT_LONG_LONG:BOOL=ON
Tpetra_INST_INT_UNSIGNED:BOOL=OFF
Tpetra_INST_INT_UNSIGNED_LONG:BOOL=OFF
Tpetra_INST_COMPLEX_FLOAT_DEFAULT:INTERNAL=OFF
Tpetra_INST_DOUBLE_DEFAULT:INTERNAL=ON
Tpetra_INST_FLOAT_DEFAULT:INTERNAL=OFF

Teuchos_ENABLE_COMPLEX:BOOL=FALSE
Teuchos_ENABLE_EXTENDED:BOOL=ON
Teuchos_ENABLE_FLOAT:BOOL=FALSE
Teuchos_ENABLE_LONG_LONG_INT:BOOL=ON

and *_EXPLICIT_INSTANTIATION:BOOL=OFF. Still, this compiles and passes the testsuite in #7180.

@davydden
Copy link

davydden commented Oct 6, 2018

I can build Trilinos with those extra _INST_'s (including complex double, complex float, float) but now I have

In file included from /Users/davydden/spack/var/spack/stage/dealii-develop-mcjvbkpu6lohho4ng2hannbqrczacmg5/dealii/source/lac/trilinos_precondition_muelu.cc:28:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/MueLu.hpp:62:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Xpetra_MapFactory.hpp:58:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Xpetra_BlockedMap.hpp:53:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Xpetra_ImportFactory.hpp:54:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Xpetra_TpetraImport.hpp:57:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_Import.hpp:2:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_Import_def.hpp:51:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_Export.hpp:2:
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_Export_def.hpp:546:31: error: no member named 'bind1st' in namespace 'std'
                         std::bind1st (std::equal_to<int>(), -1));
                         ~~~~~^
In file included from /Users/davydden/spack/var/spack/stage/dealii-develop-mcjvbkpu6lohho4ng2hannbqrczacmg5/dealii/source/lac/trilinos_precondition_muelu.cc:16:
In file included from /Users/davydden/spack/var/spack/stage/dealii-develop-mcjvbkpu6lohho4ng2hannbqrczacmg5/dealii/include/deal.II/lac/trilinos_index_access.h:19:
In file included from /Users/davydden/spack/var/spack/stage/dealii-develop-mcjvbkpu6lohho4ng2hannbqrczacmg5/dealii/spack-build/include/deal.II/base/config.h:424:
In file included from /Users/davydden/spack/var/spack/stage/dealii-develop-mcjvbkpu6lohho4ng2hannbqrczacmg5/dealii/include/deal.II/base/numbers.h:60:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Sacado.hpp:55:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Sacado_Fad_DFadTraits.hpp:152:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Sacado_Fad_ScalarTraitsImp.hpp:37:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Teuchos_SerializationTraitsHelpers.hpp:46:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Teuchos_ArrayView.hpp:47:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Teuchos_ArrayRCP.hpp:46:
In file included from /Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Teuchos_ArrayRCPDecl.hpp:47:
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Teuchos_RCP.hpp:288:5: error: cannot initialize a member subobject of type 'Teuchos::basic_FancyOStream<char, std::__1::char_traits<char> > *' with an rvalue of type 'Teuchos::ParameterList *'
  : ptr_(r_ptr.get()), // will not compile if T is not base class of T2
    ^    ~~~~~~~~~~~
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_CrsGraph_def.hpp:5032:65: note: in instantiation of function template specialization 'Teuchos::RCP<Teuchos::basic_FancyOStream<char, std::__1::char_traits<char> > >::RCP<Teuchos::ParameterList>' requested here
          exporter_ = rcp (new export_type (rowMap_, rangeMap_, exportSublist));
                                                                ^
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_CrsMatrix_def.hpp:4070:17: note: in instantiation of member function 'Tpetra::CrsGraph<int, int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace>, false>::makeImportExport' requested here
      myGraph_->makeImportExport ();
                ^
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_RowMatrix_def.hpp:284:12: note: in instantiation of member function 'Tpetra::CrsMatrix<double, int, int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace>, false>::fillComplete' requested here
        C->fillComplete (theDomainMap, theRangeMap);
           ^
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Tpetra_CrsMatrix_decl.hpp:283:5: note: in instantiation of member function 'Tpetra::RowMatrix<double, int, int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> >::add' requested here
    CrsMatrix (const Teuchos::RCP<const map_type>& rowMap,
    ^
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Xpetra_TpetraCrsMatrix.hpp:105:33: note: in instantiation of member function 'Tpetra::CrsMatrix<double, int, int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace>, false>::CrsMatrix' requested here
      : mtx_ (Teuchos::rcp (new Tpetra::CrsMatrix<Scalar, LocalOrdinal, GlobalOrdinal, Node> (toTpetra(rowMap), maxNumEntriesPerRow, toTpetra(pftype), params))) {  }
                                ^
/Users/davydden/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.0-apple/trilinos-12.12.1-siwm6o3eaibfrvrjuror7cvbblnh7kjm/include/Xpetra_CrsMatrixFactory.hpp:271:25: note: in instantiation of member function 'Xpetra::TpetraCrsMatrix<double, int, int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> >::TpetraCrsMatrix' requested here
        return rcp( new TpetraCrsMatrix<Scalar, LocalOrdinal, GlobalOrdinal, Node>(rowMap, maxNumEntriesPerRow, pftype, plist) );
                        ^

😢

EDIT: could be mac specific, but still scary that adding those extra _INST breaks things of the otherwise perfectly working build...

@masterleinad
Copy link
Member

error: no member named 'bind1st' in namespace 'std' std::bind1st (std::equal_to(), -1));

That is libc++ specific. std::bind1st was removed in the C++17 standard but libstdc++ still has it.

@masterleinad
Copy link
Member

See trilinos/Trilinos#3571.

@davydden
Copy link

davydden commented Oct 7, 2018

Thanks @masterleinad

@tjhei
Copy link
Member Author

tjhei commented Oct 7, 2018

So it looks like you keep those Tpetra_INST_ but remove Trilinos_ENABLE_EXPLICIT_?

I think INST* doesn't matter now.

Copy link
Contributor

@koecher koecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include the changes made by @masterleinad for trilinos 12.12 and apply the patch before building trilinos.

@tjhei
Copy link
Member Author

tjhei commented Oct 11, 2018

changes made by @masterleinad for trilinos 12.12

or wait for 12.14. I don't really want to put in and maintain patches in candi if we can avoid it.

@koecher
Copy link
Contributor

koecher commented Oct 12, 2018

@tjhei waiting for 12.14 would be a clean solution. I don’t know how urgent the trilinos update is, if it would help, than it must run through without any glitches since a lot of candi users need trilinos

@koecher koecher added version update updates the version of a certain package work in progress labels Oct 16, 2018
@tjhei
Copy link
Member Author

tjhei commented Mar 8, 2019

So, trilinos 12.14.1 got released: https://github.com/trilinos/Trilinos/releases/tag/trilinos-release-12-14-1

Sadly, I am getting


/ssd/candi-tmp-tril/tmp/unpack/Trilinos-trilinos-release-12-14-1/packages/kokkos-kernels/src/batched/KokkosBatched_Util.hpp:195:7: error: static assertion failed: KokkosKernels:: Invalid SIMD<> type.
       static_assert( std::is_same<T,bool>::value                     ||
       ^

@davydden You reported this bug in October, but it looks like it did not land in this release.

@tjhei tjhei changed the title update trilinos to 12.12 update trilinos Mar 8, 2019
@davydden
Copy link

davydden commented Mar 8, 2019

You reported this bug in October, but it looks like it did not land in this release.

no, it did not. trilinos/Trilinos#3574 Feel free to remind Trilinos team about this bug ;-)

@tjhei
Copy link
Member Author

tjhei commented Mar 8, 2019

no, it did not.

what is your workaround in spack? I can make it work by disabling ifpack2, but it doesn't look like this is what you do in spack.

@tjhei
Copy link
Member Author

tjhei commented Mar 11, 2019

Note: this won't work with a standard MKL installation as the BLAS does not have the necessary float instantiations. It looks like we can't do something sensible with tpetra by default...

@koecher
Copy link
Contributor

koecher commented Mar 11, 2019

It looks like we can't do something sensible with tpetra by default...

that’s not good to hear.
Anyhow, as long as we are happy with the old trilinos we should keep this as the default package. Maybe we could include a second trilinos package as non default shipping this version.

@bangerth
Copy link
Member

bangerth commented Mar 11, 2019 via email

@tjhei
Copy link
Member Author

tjhei commented Mar 28, 2019

I think that's a good point. Unless there is a reason to upgrade, we don't have to upgrade.

Agreed, but then the users of candi and the CI testers won't have access to tpetra as we don't have complex support (DEAL_II_TRILINOS_WITH_TPETRA). See dealii/dealii#7180.

@tjhei tjhei mentioned this pull request Dec 18, 2019
- update to 12.12
- enable complex support
- require tpetra and add instantiations (fixes problems in
dealii/dealii#7180 )
- disable boost (not needed and causes build to fail)
@tjhei
Copy link
Member Author

tjhei commented Dec 23, 2019

I updated to the latest 12.18.1 release and did various tests:

  • ubuntu 16 (mpich, gcc 5.4)
  • OSX (openmpi, gcc 9.2)
  • centos with intel compilers, intel mpi, and MKL

I think this is good to go. The only caveat is that we disable Tpetra when using MKL, which is not ideal, but I don't know how to fix that.

@koecher
Copy link
Contributor

koecher commented Dec 24, 2019

happy days. thank you so much @tjhei and merry christmas

@koecher koecher merged commit f8722b9 into dealii:master Dec 24, 2019
@tjhei tjhei deleted the update_trilinos_12_12 branch June 23, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version update updates the version of a certain package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants