Add distributed moving laser heating #92

MarkMa1990 · 2021-12-02T17:23:17Z

This program aims to solve the non-uniform isotropic heat equation with distributed memory.

as suggested by wolfgang, the program is moved here.
dealii/dealii#13023 (comment)

change dependency

add figures in readme

correct images

peterrum

Sorry for getting to this so later. I left some comments. Looks overall good.

Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc

peterrum · 2022-06-16T17:18:23Z

Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc

+// this library is deprecated. use affine_constraints.h instead
+//#include <deal.II/lac/constraint_matrix.h>


Suggested change

// this library is deprecated. use affine_constraints.h instead

//#include <deal.II/lac/constraint_matrix.h>

Suggested change

// this library is deprecated. use affine_constraints.h instead

//#include <deal.II/lac/constraint_matrix.h>

// this library is deprecated. use affine_constraints.h instead

//#include <deal.II/lac/constraint_matrix.h>

peterrum · 2022-06-16T17:18:49Z

Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc

+#ifndef GLOBAL_PARA
+#define GLOBAL_PARA
+#include "./globalPara.h"
+#include "./boundaryInit.h"
+#include "./rightHandSide.h"
+#endif


Is this ifdef needed?

peterrum · 2022-06-16T17:18:50Z

Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc

+#ifndef GLOBAL_PARA
+#define GLOBAL_PARA
+#include "./globalPara.h"
+#include "./boundaryInit.h"
+#include "./rightHandSide.h"
+#endif


Is this ifdef needed?

peterrum · 2022-06-16T17:30:22Z

Distributed_Moving_Laser_Heating/doc/tooltip

@@ -0,0 +1 @@
+Laplace equation surface coupled to an external simulation program (here simply a fancy boundary condition) using the coupling library preCICE.


Distributed_Moving_Laser_Heating/docs_old/intro.dox

peterrum · 2022-06-16T17:31:25Z

Distributed_Moving_Laser_Heating/docs_old/intro.dox

+where $n$ is the time step number, and $dt$ is the time step.
+
+<h3> The initial condition </h3>
+Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,


Suggested change

Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,

deall.II provides an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,

Suggested change

Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,

Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,

Distributed_Moving_Laser_Heating/README.md

peterrum · 2022-06-16T17:33:00Z

Distributed_Moving_Laser_Heating/README.md

+
+![illustration](./images/structure-2d.png)
+
+## numerical results


Suggested change

## numerical results

## Numerical results

Suggested change

## numerical results

## numerical results

bangerth · 2022-07-18T21:38:26Z

@MarkMa1990 I will second @peterrum 's observation that we let this sit around for too long without giving you feedback :-(

@peterrum left a number of comments on this program. Do you think you have the time to address them and upload a new version? I will then look at it as well!

MarkMa1990 · 2022-07-18T21:45:52Z

yes, I will do it this weekend. thanks for the reply Wolfgang Bangerth ***@***.***> 于2022年7月18日周一 23:38写道：

…

@MarkMa1990 <https://github.com/MarkMa1990> I will second @peterrum <https://github.com/peterrum> 's observation that we let this sit around for too long without giving you feedback :-( @peterrum <https://github.com/peterrum> left a number of comments on this program. Do you think you have the time to address them and upload a new version? I will then look at it as well! — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACRNXAWWMEQQQPYMIULGU4LVUXFFZANCNFSM5JHVTTLA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

bangerth · 2022-07-18T21:49:40Z

Excellent, we look forward to it!

Co-authored-by: Peter Munch <peterrmuench@gmail.com>

delete the commented petsc part

…ing.cc accepted Co-authored-by: Peter Munch <peterrmuench@gmail.com>

…ing.cc Co-authored-by: Peter Munch <peterrmuench@gmail.com>

bangerth · 2023-03-10T05:49:34Z

Oh, did we never notice that you updated all of the things that @peterrum had commented on? In other words, is this ready to be merged from your side?

bangerth · 2023-03-10T05:50:25Z

My apologies that none of us saw that! In the future, add a comment whenever you address comments and we know that we should take another look.

marcfehling

I've made a few changes so that your program compiles and runs with the latest deal.II 9.4.0 release.

I have one question: What is the purpose of the docs_old folder? If it doesn't serve any purpose, I would vote to delete it. There is documentation in that folder though, i.e. intro.dox and results.dox, that we should save and move to docs.

Otherwise I would say that after @peterrum's extensive review this is ready to merge.

marcfehling · 2023-04-27T06:08:17Z

I did another force push to make sure that this code compiles on the new CI workflow introduced in #142.

peterrum

Thanks!

peterrum · 2022-06-16T17:18:09Z

Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc

+/*
+#include <deal.II/lac/petsc_parallel_vector.h>
+#include <deal.II/lac/petsc_parallel_sparse_matrix.h>
+#include <deal.II/lac/petsc_solver.h>
+#include <deal.II/lac/petsc_precondition.h>
+*/


MarkMa1990 and others added 4 commits December 2, 2021 17:51

add moving laser heating

c0f8ddc

change dependency

be2c26b

change dependency

add figures in readme

eb1a11c

add figures in readme

correct images

dfbc47d

correct images

peterrum reviewed Jun 16, 2022

View reviewed changes

MarkMa1990 and others added 9 commits July 25, 2022 10:09

Update Distributed_Moving_Laser_Heating/README.md

103fdf8

Co-authored-by: Peter Munch <peterrmuench@gmail.com>

Update entry-name

ec42dba

Update tooltip

b3fd52c

Update Distributed_Moving_Laser_Heating/docs_old/intro.dox

e444d37

Co-authored-by: Peter Munch <peterrmuench@gmail.com>

Update rightHandSide.h

611acd8

Update Distributed_Moving_Laser_Heating.cc

63faf71

delete the commented petsc part

Update Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heat…

95816f2

…ing.cc accepted Co-authored-by: Peter Munch <peterrmuench@gmail.com>

Update Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heat…

74d1099

…ing.cc Co-authored-by: Peter Munch <peterrmuench@gmail.com>

Update Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heat…

f91511d

…ing.cc Co-authored-by: Peter Munch <peterrmuench@gmail.com>

marcfehling approved these changes Apr 23, 2023

View reviewed changes

marcfehling force-pushed the master branch 3 times, most recently from 549fe5e to 7aef0d6 Compare April 27, 2023 06:07

Make code compile with deal.II 9.4.0.

7aef0d6

Mark functions with override.

5b7f39d

peterrum approved these changes May 18, 2023

View reviewed changes

peterrum merged commit f2bfb2a into dealii:master May 18, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add distributed moving laser heating #92

Add distributed moving laser heating #92

MarkMa1990 commented Dec 2, 2021

peterrum left a comment

peterrum Jun 16, 2022

peterrum Jun 16, 2022

peterrum Jun 16, 2022

peterrum Jun 16, 2022

peterrum Jun 16, 2022

peterrum Jun 16, 2022

bangerth commented Jul 18, 2022

MarkMa1990 commented Jul 18, 2022 via email

bangerth commented Jul 18, 2022

bangerth commented Mar 10, 2023

bangerth commented Mar 10, 2023

marcfehling left a comment •

edited

marcfehling commented Apr 27, 2023

peterrum left a comment

peterrum Jun 16, 2022

		// this library is deprecated. use affine_constraints.h instead
		//#include <deal.II/lac/constraint_matrix.h>

		@@ -0,0 +1 @@
		Laplace equation surface coupled to an external simulation program (here simply a fancy boundary condition) using the coupling library preCICE.

	Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,
	deall.II provides an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial,


		![illustration](./images/structure-2d.png)

		## numerical results

Add distributed moving laser heating #92

Add distributed moving laser heating #92

Conversation

MarkMa1990 commented Dec 2, 2021

peterrum left a comment

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

bangerth commented Jul 18, 2022

MarkMa1990 commented Jul 18, 2022 via email

bangerth commented Jul 18, 2022

bangerth commented Mar 10, 2023

bangerth commented Mar 10, 2023

marcfehling left a comment • edited

Choose a reason for hiding this comment

marcfehling commented Apr 27, 2023

peterrum left a comment

Choose a reason for hiding this comment

peterrum Jun 16, 2022

Choose a reason for hiding this comment

marcfehling left a comment •

edited