Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code gallery: broken internal hyperlinks #10295

Closed
stmcgovern opened this issue May 21, 2020 · 6 comments · Fixed by #10930
Closed

code gallery: broken internal hyperlinks #10295

stmcgovern opened this issue May 21, 2020 · 6 comments · Fixed by #10930

Comments

@stmcgovern
Copy link

Hi,
I was doing some browsing of the code gallery today and I noticed that the "(click to inspect):" links were not returning pages, while the main descriptions pages of codes are fine.
Example:
https://dealii.org/developer/doxygen/code-gallery/time_dependent_navier_stokes/Readme.md

Just feedback.
Best,
Sean

@drwells
Copy link
Member

drwells commented May 23, 2020

Thanks for the report. @jppelteret do you have time to take a look?

@jppelteret
Copy link
Member

I don't think that I'm the right person for the job @drwells. The can confirm that the generated links point to some non-existent place on the website, and since I don't have access to the website data I cannot infer where it should be pointing to! Or am I missing something obvious?

@drwells
Copy link
Member

drwells commented May 23, 2020

The issue is a result of how we generate the code gallery programs - we create links to all the files in the repository, if I recall correctly. It's not directly related to what is on the website.

@jppelteret
Copy link
Member

jppelteret commented Jul 6, 2020

@bangerth I'm not sure if you're aware of this issue, but the internal links in the code-gallery are all broken. Any tips on where I can look to fix them? I've got zero familiarity with how this all is set up, but I guess I can make an attempt to fix it.

cc @ecomellas

@bangerth
Copy link
Member

Curiously, if I generate this on my own machine, it works. I wonder what difference that makes -- do they just not get installed? I'm looking at my build directory, where these files are present. I need to check what happens upon installation next, but first need to get myself to a (virtual) happy hour.

@bangerth
Copy link
Member

I confirmed that it now all seems to work. Thanks, @stmcgovern for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants