Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-19: Revise discussion about time stepping + update movie #10945

Closed
kronbichler opened this issue Sep 22, 2020 · 6 comments · Fixed by #15365
Closed

step-19: Revise discussion about time stepping + update movie #10945

kronbichler opened this issue Sep 22, 2020 · 6 comments · Fixed by #15365
Assignees
Milestone

Comments

@kronbichler
Copy link
Member

As discussed in #10942 (comment) , the tutorial program is a bit inconsistent in the convention for the time step. In particular, I believe that the result section should not call the method "forward Euler" because the formula is indeed using the end-of-step electrical potential/field, but it might be that something else was intended anyway. Given #10942, at least the formulas in the introduction and in-code comments should be consistent with what is implemented.

@kronbichler kronbichler changed the title [step-19] Revise discussion about time stepping step-19: Revise discussion about time stepping + update movie Sep 23, 2020
@kronbichler
Copy link
Member Author

Furthermore, I get a different motion of particles with #10942, so I believe the movie needs to be updated as well.

@kronbichler kronbichler added this to the Release 9.3 milestone Sep 23, 2020
@peterrum peterrum modified the milestones: Release 9.3, Release 10.0 May 1, 2021
@peterrum
Copy link
Member

peterrum commented May 1, 2021

This does not seem urgent.

@bangerth bangerth self-assigned this May 3, 2021
@bangerth bangerth modified the milestones: Release 10.0, Release 9.3 May 3, 2021
@bangerth
Copy link
Member

bangerth commented May 3, 2021

I'd like to get this done, given that step-19 is new in this release.

@peterrum
Copy link
Member

I'd like to get this done, given that step-19 is new in this release.

@bangerth It would be nice if the documentation would be updated. The movie is not that important.

@tamiko tamiko modified the milestones: Release 9.3, Release 10.0 May 22, 2021
@kronbichler
Copy link
Member Author

I guess this is a very minor topic and does not distract from the main innovation of the tutorial, so I simply adjust the milestone for now. If we have a last-minute fix, I will be fine with it as well.

@kronbichler kronbichler modified the milestones: Release 9.4, Release 9.5 May 30, 2022
@kronbichler
Copy link
Member Author

@bangerth do you see a chance to get this done for the release? I do not think this is super urgent, so we might also remove the target milestone and/or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants