Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-22 uses extractors for the matrix but not for the right hand side #11039

Closed
bangerth opened this issue Oct 12, 2020 · 1 comment · Fixed by #12988
Closed

step-22 uses extractors for the matrix but not for the right hand side #11039

bangerth opened this issue Oct 12, 2020 · 1 comment · Fixed by #12988

Comments

@bangerth
Copy link
Member

That's a shame, because step-22 is one of the often used tutorial programs to introduce how we conceptually think about vector-valued problems. Specifically, we should just re-write this block of code:

      const unsigned int component_i =
        fe.system_to_component_index(i).first;
      local_rhs(i) += (fe_values.shape_value(i, q)   // (phi_u_i(x_q)
                       * rhs_values[q](component_i)) // * f(x_q))
                      * fe_values.JxW(q);            // * dx
@bangerth bangerth added this to the Release 9.3 milestone Oct 12, 2020
@peterrum peterrum modified the milestones: Release 9.3, Release 10.0 May 1, 2021
@peterrum
Copy link
Member

peterrum commented May 1, 2021

This does not seem urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants