Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make the new shape face numberings more lexical? #11124

Open
drwells opened this issue Oct 31, 2020 · 2 comments
Open

Should we make the new shape face numberings more lexical? #11124

drwells opened this issue Oct 31, 2020 · 2 comments

Comments

@drwells
Copy link
Member

drwells commented Oct 31, 2020

I noticed while writing #11121 that, for a pyramid, we implement face 0 as the base. I think it would be more logical to make this face 4 since it is in the same place as face 4 of the hexahedron. We could then renumber the other faces to also more closely match the hexahedral numbering scheme and do the same with wedge faces.

I'd like to do this before we get further along with mixed mesh support. What do y'all think?

@bangerth
Copy link
Member

Can you try what happens? I don't know where that would break things, but it might be worth just trying it out.

@drwells
Copy link
Member Author

drwells commented Oct 19, 2021

Sure. We need to merge some of those PRs first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants