New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step-44: Use FE_DGP instead of FE_DGPMonomial? #11612
Comments
FYI @mschreter |
@jppelteret I have no recollection why we chose FE_DGPMonomial. We did explore both options at the time though. I agree though, it seems it could improve conditioning. Worth investigating. |
Thanks for your reply! I recall the same, but I thought I might be imagining it! Maybe there was some confounding error in the code when we did so. I'll do a small parametric study to see if such a change would be robust. |
I seem to recall that we had an issue setting J = 1 as the initial condition for the dilatation. |
I would expect |
I've attached some logs below for tests using poly orders 1-4 with the grid refinement level decreased as p increases. There's no change in the number of linear solver iterations for p=1, but a significant improvement at p=4.
|
After a discussion with @peterrum, I was compelled to try substituting the
FE_DGPMonomial
used for step-44's pressure and dilatation fields byFE_DGP
. After re-reading the documentation for these two classes, it appeared to me thatFE_DGP
should work just fine. In order to satisfy the LBB condition, the requirement of the fields is that they are discontinuous, of one degree lower than the displacement field, and contain the complete polynomials of the FE space (see Hughes "The Finite Element Method" p295/296). For example, in 2d a bi-quadratic displacement must be paired with a piece-wise linear (not bilinear) pressure and dilatation. Both theFE_DGP
andFE_DGPMonomial
classes claim to do this, with the main difference between them being the following:So it would seem that we can expect both to work, and should observe a difference in condition number of the linear system. I've tested this with order 4 displacement (and corresponding order 3 pressure and displacement fields) and this does seem to be the case. The
FE_DGP
seem to give superior performance.step-44-Q(4)_DGP(3)_DGP(3).txt
step-44-Q(4)_DGPMonomial(3)_DGPMonomial(3).txt
Unfortunately, I cannot recall why we chose the
FE_DGPMonomial
element as opposed to theFE_DGP
. @mac-a, do you have any recollection as to why we did this? I propose that we investigate changing the element type for these discontinuous fields, on the basis of an increase in performance with no apparent decrease in the accuracy of the element.step-44.cc.txt
The text was updated successfully, but these errors were encountered: