Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParameterHandler::add_parameter fails for map<int,pair<int,int>> with custom separators #12477

Closed
sebproell opened this issue Jun 19, 2021 · 3 comments · Fixed by #12600 or #12788
Closed

Comments

@sebproell
Copy link
Contributor

I wanted to add a parameter of type std::map<int, std::pair<int,int>> with ParameterHandler::add_parameter. This works as long as I use the default separators. However, if I use (prettier) custom separators, the verfication of the default value fails. A subsequent read also fails. I added a test here: https://github.com/sebproell/dealii/blob/add-parameter-map-tuple/tests/parameter_handler/patterns_17.cc#L55-L75

Is this a bug or am I not using the function properly? As you can see in the test, the custom pattern clearly works and matches the string. The error seems to indicate that the custom separator gets lost somewhere. I can spend some time to hunt this down, if it really is a bug. WDYT?

@drwells
Copy link
Member

drwells commented Jul 27, 2021

@sebproell this is closed, but would you mind putting up a PR with the change to the test? I don't think that was in #12600.

@sebproell
Copy link
Contributor Author

@drwells I can do this but probably not before mid August.

@drwells
Copy link
Member

drwells commented Jul 27, 2021

Lets keep this open for now and we can close again once the test is in too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants