Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize a small aspect of step-20/21 #13110

Closed
bangerth opened this issue Dec 23, 2021 · 0 comments · Fixed by #13191
Closed

Modernize a small aspect of step-20/21 #13110

bangerth opened this issue Dec 23, 2021 · 0 comments · Fixed by #13191

Comments

@bangerth
Copy link
Member

#13109 simplifies the initialization of block matrices and vectors by passing a vector of block sizes to the overarching block object, rather than initializing the blocks individually and then calling .collect_sizes() on the overarching object.

step-20 and step-21 are the remaining hold-outs. They do things differently, and a bit more thought is required. The documentation also needs to be adjusted as there is a lengthy text block explaining the way it is done right now.

Separately, at least one of these two still uses non-dynamic sparsity patterns. We should drop this -- it's not efficient, and we should never do that anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant