Remove fields from Mapping::InternalDataBase. #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that all of the non-is_first_cell/clear_first_cell() member variables of Mapping::InternalDataBase are only referenced in Mapping member functions that are unused throughout the rest of the library. While they were public, they took an internal object as argument, so were almost certainly not used anywhere by anyone. Consequently, zap the fields and the functions that use them.
kronbichler
added a commit
that referenced
this pull request
Aug 12, 2015
Remove fields from Mapping::InternalDataBase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that all of the non-is_first_cell/clear_first_cell() member
variables of Mapping::InternalDataBase are only referenced in Mapping
member functions that are unused throughout the rest of the library.
While they were public, they took an internal object as argument, so
were almost certainly not used anywhere by anyone. Consequently,
zap the fields and the functions that use them.
This fixes #1317 in a magically simple way. Relates to #1198.