Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning in step-81 #13890

Closed
zjiaqi2018 opened this issue Jun 1, 2022 · 2 comments · Fixed by #13892
Closed

Warning in step-81 #13890

zjiaqi2018 opened this issue Jun 1, 2022 · 2 comments · Fixed by #13892
Milestone
Release 9.4

Comments

@zjiaqi2018
Copy link
Contributor

Got this warning while building deal.ii master:

dealii/examples/step-81/step-81.cc:343:22: warning: imaginary constants are a GCC extension
         return 1.0 + 1.0i * s_bar;

configuration:


#                                (version 9.4.0-pre, shortrev 2781423784)
#        CMAKE_CXX_COMPILER:     GNU 7.5.0 on platform Linux x86_64
#                                /usr/bin/c++
#        C++ language standard:  C++14
@bangerth
Copy link
Member

bangerth commented Jun 1, 2022

This should be std::complex<double>(1.0,s_bar). Want to give this a try to see whether the warning disappears?

@bangerth bangerth added this to the Release 9.4 milestone Jun 1, 2022
@zjiaqi2018
Copy link
Contributor Author

zjiaqi2018 commented Jun 1, 2022 •
edited

Yes, the warnings are gone. I will open a PR. Thanks!

@zjiaqi2018 zjiaqi2018 mentioned this issue Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 9.4
Development

Successfully merging a pull request may close this issue.

Fix step-81 complex number warnings zjiaqi2018/dealii
2 participants
@bangerth @zjiaqi2018