Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete trailing whitespace in the changes.h file #13997

Closed
drwells opened this issue Jun 16, 2022 · 3 comments
Closed

Delete trailing whitespace in the changes.h file #13997

drwells opened this issue Jun 16, 2022 · 3 comments

Comments

@drwells
Copy link
Member

drwells commented Jun 16, 2022

This is mildly annoying - we should modify the cmake script to delete trailing whitespace.

@CodyGirl
Copy link
Contributor

Hello Team,

I was trying to replicate this issue in order to contribute to deal.ii but can't seem to replicate it. The changes.h file did not have any trailing white spaces. If you're still able to see those trailing white spaces please let me know how to replicate it.

@drwells
Copy link
Member Author

drwells commented Dec 13, 2022

Perhaps we are looking at different files - I see trailing whitespace in build/doc/news/changes.h (where build is my build directory). Independently of that, we should still add code to trim trailing whitespace into the CMake script which creates this file - can you give that a try?

@drwells
Copy link
Member Author

drwells commented Jan 6, 2024

Fixed by #16419.

@drwells drwells closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants