Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEEvaluation: Unify code for Jacobian gradient #14008

Open
kronbichler opened this issue Jun 17, 2022 · 1 comment
Open

FEEvaluation: Unify code for Jacobian gradient #14008

kronbichler opened this issue Jun 17, 2022 · 1 comment

Comments

@kronbichler
Copy link
Member

With #13990, we introduced a second variable for storing the plain Jacobian gradients, without the inverse Jacobians applied as a transformation as in the field

std::array<
AlignedVector<
Tensor<1, spacedim *(spacedim + 1) / 2, Tensor<1, spacedim, Number>>>,
2>
jacobian_gradients;

It would be better to use the untransformed Jacobian gradient also for the Hessian, in order to reduce the memory consumed/accessed by these large arrays. We should aim to fix this for the next release.

@kronbichler kronbichler added this to the Release 9.5 milestone Jun 17, 2022
@kronbichler
Copy link
Member Author

This is an important step for optimizing H(div) elements with the matrix-free framework, that should be tackled soon. But it is not urgent for the upcoming release, so I'm adjusting the target milestone.

@kronbichler kronbichler modified the milestones: Release 9.5, Release 9.6 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant