Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new CMake build system requires CMake 3.18 #14949

Closed
drwells opened this issue Mar 22, 2023 · 3 comments · Fixed by #14960
Closed

The new CMake build system requires CMake 3.18 #14949

drwells opened this issue Mar 22, 2023 · 3 comments · Fixed by #14960
Labels
Build system

Comments

@drwells
Copy link
Member

drwells commented Mar 22, 2023

When I try to configure the test suite (using cmake 3.16) I see

CMake Error at [...]/dealii/build/share/deal.II/macros/macro_deal_ii_setup_target.cmake:107 (target_link_options):
  Error evaluating generator expression:

    $<LINK_LANGUAGE:CXX>

but this feature is new in CMake 3.18.
@peterrum
Copy link
Member

I have the same issue.

This was referenced Mar 23, 2023
Closed
Merged
@drwells
Copy link
Member Author

drwells commented Mar 23, 2023

We should fix this, but before I start hacking away at it - do we want to increment the minimum version past 3.13.4? I'd prefer not to go past 3.16 since that's what is available in Ubuntu 20.04.

@tamiko
Copy link
Member

tamiko commented Mar 23, 2023

Let us simply remove the $<LINK_LANGUAGE:CXX> generator expression. I did add it proactively - it has little value.

@drwells drwells mentioned this issue Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the LINK_LANGUAGE:CXX generator. drwells/dealii
3 participants
@tamiko @drwells @peterrum