Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Algorithms::Newton? #15026

Open
tjhei opened this issue Apr 4, 2023 · 2 comments
Open

Remove Algorithms::Newton? #15026

tjhei opened this issue Apr 4, 2023 · 2 comments

Comments

@tjhei
Copy link
Member

tjhei commented Apr 4, 2023

I just discovered https://www.dealii.org/developer/doxygen/deal.II/classAlgorithms_1_1Newton.html
which is an implementation of Newton's method with linear search but it uses OperatorBase and the string-based AnyData, which is not a modern design we ended up using in many places.

This class is not used in any tutorial program but tests exist in tests/algorithms/.

My vote would be to remove it without deprecation. Objections?

(somewhat related to #14799)
@drwells
Copy link
Member

drwells commented Apr 4, 2023

Should we also deprecate OperatorBase?

@bangerth
Copy link
Member

bangerth commented Apr 5, 2023

Nuke it. We have interfaces to ROL and KINSOL and NOX that are all almost certainly far superior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tjhei @drwells @bangerth