Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields are not reset during MappingInfo().reinit_*() #15305

Closed
jh66637 opened this issue Jun 5, 2023 · 1 comment · Fixed by #15358
Closed

Fields are not reset during MappingInfo().reinit_*() #15305

jh66637 opened this issue Jun 5, 2023 · 1 comment · Fixed by #15358

Comments

@jh66637
Copy link
Contributor

jh66637 commented Jun 5, 2023

@bergbauer

During adding the test in #15292 I found that some fields are not cleared before they are filled again in reinint_*(). Therefore, having a sequence of reinits leads to unwanted behavior.

In my case, I called reinit_faces() and reinit_cells() on the same MappingInfo object and got the wrong JxW due to a mismatch of quadrature indices. Using a new object works. In this particular case, e.g., n_q_points_unvectorized is not cleared in reinit_cells(). I can fix that, but I am not as familiar with all the code and will probably forget some fields which should be cleared. Would you mind taking a look?

@bergbauer
Copy link
Contributor

I will have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants