Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check vector concepts for all of our solvers. #15638

Closed
bangerth opened this issue Jul 3, 2023 · 2 comments · Fixed by #17010
Closed

Check vector concepts for all of our solvers. #15638

bangerth opened this issue Jul 3, 2023 · 2 comments · Fixed by #17010

Comments

@bangerth
Copy link
Member

bangerth commented Jul 3, 2023

#15637 creates a concept for what constitutes a vector-space-vector. We should annotate all of our solver classes with this requirement.

The files in question are specifically these:

> egrep -l -r 'class Solver' include/deal.II/lac/
include/deal.II/lac/solver_selector.h
include/deal.II/lac/solver_minres.h
include/deal.II/lac/solver_qmrs.h
include/deal.II/lac/trilinos_sparse_matrix.h
include/deal.II/lac/solver_idr.h
include/deal.II/lac/petsc_solver.h
include/deal.II/lac/solver_bicgstab.h
include/deal.II/lac/solver_richardson.h
include/deal.II/lac/solver_gmres.h
include/deal.II/lac/ginkgo_solver.h
include/deal.II/lac/slepc_spectral_transformation.h
include/deal.II/lac/trilinos_precondition.h
include/deal.II/lac/solver_relaxation.h
include/deal.II/lac/solver_control.h
include/deal.II/lac/solver_cg.h
include/deal.II/lac/solver.h
include/deal.II/lac/cuda_solver_direct.h
include/deal.II/lac/trilinos_solver.h
include/deal.II/lac/slepc_solver.h
include/deal.II/lac/solver_fire.h
@bangerth bangerth added this to the Developer workshop 2023 milestone Jul 3, 2023
@bangerth
Copy link
Member Author

bangerth commented Jul 3, 2023

This would also address at least a part of what we had intended with the VectorSpaceVector class (see #3073).

@bangerth
Copy link
Member Author

#16995 adds vector space concepts for the VectorType template argument of solvers. I did not yet add constraints on the MatrixType and PreconditionerType template arguments yet, but that is next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant