Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tester regressed 0452d8 #16275

Closed
tamiko opened this issue Nov 17, 2023 · 3 comments
Closed

Regression tester regressed 0452d8 #16275

tamiko opened this issue Nov 17, 2023 · 3 comments
Labels
Regression tester Issues reported by the regression tester bot

Comments

@tamiko
Copy link
Member

tamiko commented Nov 17, 2023

[start automated regression testsuite report]

Dear all,

this is the automated regression testsuite reporting a new regression between

Summary:

I have identified the following pull requests as possible candidates:

Notes:

[end automated regression testsuite report]

@tamiko tamiko added the Regression tester Issues reported by the regression tester bot label Nov 17, 2023
@tamiko tamiko pinned this issue Nov 17, 2023
@RichardYCJ
Copy link
Contributor

Seems the partial specialization function compute_intersection_of_cells<2, 2, 2, 4, 4> directly push elements into collection instead of the temporary variable vertices. So maybe just delete vertices?

This relates to a commit a long time ago but somehow fails to be caught by the compiler. I'm not sure whether the constexpr of Point would help to detect these problems.

@bangerth
Copy link
Member

Yes, we should just remove that variable since it's now unused. @RichardYCJ Want to write a patch?

@tamiko
Copy link
Member Author

tamiko commented Nov 18, 2023

[automated regression testsuite]

Regression tester reported a clean run compared to baseline. 😊
Closing all issues. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression tester Issues reported by the regression tester bot
Projects
None yet
Development

No branches or pull requests

3 participants