Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression tester regressed 8245d5 #16463

Closed
tamiko opened this issue Jan 12, 2024 · 2 comments
Closed

Regression tester regressed 8245d5 #16463

tamiko opened this issue Jan 12, 2024 · 2 comments
Labels
High Priority ⚠️ Regression tester Issues reported by the regression tester bot

Comments

@tamiko
Copy link
Member

tamiko commented Jan 12, 2024 •
edited

[start automated regression testsuite report]

Dear all,

this is the automated regression testsuite reporting a new regression between

Summary:

I have identified the following pull requests as possible candidates:

Notes:

[end automated regression testsuite report]
@tamiko tamiko added the Regression tester Issues reported by the regression tester bot label Jan 12, 2024
@tamiko tamiko pinned this issue Jan 12, 2024
@tamiko tamiko unpinned this issue Jan 17, 2024
@tamiko tamiko pinned this issue Jan 19, 2024
@tamiko
Copy link
Member Author

tamiko commented Jan 19, 2024

@bangerth @masterleinad @tjhei I want to draw your attention to this regression tester run. The "64-bit" and "minimal bundled" variants show a massive fallout of failing tests and I am guessing it is the DEAL_II_ASSUME macro.

We need to fix this. I will try to get a stacktrace and some debugging info going tomorrow.

@tamiko tamiko mentioned this issue Jan 19, 2024
Closed
@tamiko
Copy link
Member Author

tamiko commented Jan 19, 2024 •
edited

This is bad. I completely miscompile with gcc-13 and DEAL_II_ASSUME enabled. For instance:

bits/fe_system.release:

% diff -Nur /home/tamiko/workspace/dealii/build-assume/tests/bits/fe_system.release/output /home/tamiko/workspace/dealii/tests/bits/fe_system.output
--- /home/tamiko/workspace/dealii/build-assume/tests/bits/fe_system.release/output      2024-01-19 10:57:35.037064376 -0600
+++ /home/tamiko/workspace/dealii/tests/bits/fe_system.output   2024-01-17 12:24:51.743409739 -0600
@@ -1,6 +1,7 @@
 
-DEAL::    2 = 0
-    28 0:  0.5
+DEAL::    28 0:  0.5
+    28 2:  0.5
+    29 2:  0.5
     29 4:  0.5
 
 DEAL::ok

bits/fe_tools_07.release:

/usr/lib/gcc/x86_64-pc-linux-gnu/13/include/g++-v13/bits/stl_vector.h:1125: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = int; _Alloc = std::allocator<int>; reference = int&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.

Thread 1 "fe_tools_07.rel" received signal SIGABRT, Aborted.
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
warning: 44     pthread_kill.c: No such file or directory
(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x00007fffd5cd9463 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
#2  0x00007fffd5c89266 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007fffd5c718b7 in __GI_abort () at abort.c:79
#4  0x00007fffcb30955f in std::__glibcxx_assert_fail (file=<optimized out>, line=<optimized out>, function=<optimized out>, condition=<optimized out>)
    at /var/tmp/portage/sys-devel/gcc-13.2.1_p20240113-r1/work/gcc-13-20240113/libstdc++-v3/src/c++11/assert_fail.cc:41
#5  0x00007ffff63fdafb in unsigned int dealii::internal::TriaAccessorImplementation::Implementation::vertex_index<3, 3>(dealii::TriaAccessor<1, 3, 3> const&, unsigned int) ()
   from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#6  0x00007ffff6c1b653 in dealii::Triangulation<3, 3>::DistortedCellList dealii::internal::TriangulationImplementation::Implementation::execute_refinement_isotropic<3>(dealii::Triangulation<3, 3>&, bool) [clone .isra.0] () from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#7  0x00007ffff6d575a9 in dealii::Triangulation<3, 3>::DistortedCellList dealii::internal::TriangulationImplementation::Implementation::execute_refinement<3>(dealii::Triangulation<3, 3>&, bool) [clone .isra.0] () from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#8  0x00007ffff6d65314 in dealii::internal::TriangulationImplementation::PolicyWrapper<3, 3, dealii::internal::TriangulationImplementation::Implementation>::execute_refinement(dealii::Triangulation<3, 3>&, bool) () from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#9  0x00007ffff6cda6e7 in dealii::Triangulation<3, 3>::execute_refinement() () from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#10 0x00007ffff6d70afe in dealii::Triangulation<3, 3>::execute_coarsening_and_refinement() () from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#11 0x00007ffff6c8af65 in dealii::Triangulation<3, 3>::refine_global(unsigned int) () from /home/tamiko/workspace/dealii/build-assume/lib/libdeal_II.so.9.6.0-pre
#12 0x00005555555c6a2a in dealii::Triangulation<3, 3>* make_tria<3>() ()
#13 0x00005555555c6bc0 in void check_this<3>(dealii::FiniteElement<3, 3> const&, dealii::FiniteElement<3, 3> const&) ()
#14 0x00005555555c8ed3 in main ()

@tamiko tamiko mentioned this issue Jan 19, 2024
Merged
@tamiko tamiko closed this as completed Jan 20, 2024
@tamiko tamiko unpinned this issue Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Priority ⚠️ Regression tester Issues reported by the regression tester bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tamiko