Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constructor Quadrature(unsigned int). #16818

Open
bangerth opened this issue Mar 29, 2024 · 0 comments · May be fixed by #17017
Open

Remove constructor Quadrature(unsigned int). #16818

bangerth opened this issue Mar 29, 2024 · 0 comments · May be fixed by #17017
Milestone

Comments

@bangerth
Copy link
Member

My exchange student wanted QGauss<dim>(3), but accidentally did Quadrature<dim>(3). This creates a quadrature formula with three points, all at the origin, and weight zero. Perhaps not surprisingly, in hindsight, all his integrals were zero. It was not what he wanted.

I think we should remove this constructor, or at least make it protected. It doesn't create a useful object, and leads to hard-to-spot mistakes.

@bangerth bangerth added this to the Release 9.6 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant