Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tester regressed e23583 #16846

Closed
tamiko opened this issue Apr 3, 2024 · 2 comments · Fixed by #16849
Closed

Regression tester regressed e23583 #16846

tamiko opened this issue Apr 3, 2024 · 2 comments · Fixed by #16849
Labels
Regression tester Issues reported by the regression tester bot

Comments

@tamiko
Copy link
Member

tamiko commented Apr 3, 2024

[start automated regression testsuite report]

Dear all,

this is the automated regression testsuite reporting a new regression between

Summary:

I have identified the following pull requests as possible candidates:

Notes:

  • The regression reported above is a subset of the following full set of regressions compared to the baseline:
  • I will close and unpin this issue automatically once a full run is complete and compares cleanly to the baseline.
  • If closed I will reopen the issue if the testsuite run identified an additional regression compared to what I have reported so far.

[end automated regression testsuite report]

@tamiko tamiko added the Regression tester Issues reported by the regression tester bot label Apr 3, 2024
@tamiko tamiko pinned this issue Apr 3, 2024
@bangerth
Copy link
Member

bangerth commented Apr 3, 2024

This is:

--------------------------------------------------------
An error occurred in line <75> of file </scratch/users/testsuite/testsuite-Exjc50B8/dealii/tests/fe/fe_values_view_07.cc> in function
    void test(const dealii::Triangulation<dim, dim>&, const dealii::FiniteElement<dim>&) [with int dim = 3]
The violated condition was: 
    (scalar_values[q] - vector_values[q][c]).norm() <= 1e-12 * scalar_values[q].norm()
Additional information: 
    This exception -- which is used in many places in the library --
    usually indicates that some condition which the author of the code
    thought must be satisfied at a certain point in an algorithm, is not
    fulfilled. An example would be that the first part of an algorithm
    sorts elements of an array in ascending order, and a second part of
    the algorithm later encounters an element that is not larger than the
    previous one.
    
    There is usually not very much you can do if you encounter such an
    exception since it indicates an error in deal.II, not in your own
    program. Try to come up with the smallest possible program that still
    demonstrates the error and contact the deal.II mailing lists with it
    to obtain help.

I think we talked about that at some other point in time already.

@tamiko tamiko unpinned this issue Apr 4, 2024
@tamiko
Copy link
Member Author

tamiko commented Apr 4, 2024

@bangerth Yup. Depending on moon cycle some instruction gets reordered and we trigger this thing. I unfortunately didn't find the time to submit a patch for this today.

So if someone beats me to it: I suggest to replace the Assert(A <= 1.e-12 * B, ...) logic with Assert(A <= 1.e-14 || A <= 1.e-12 * B, ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression tester Issues reported by the regression tester bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants