Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish rewriting the documentation of class FiniteElement. #1925

Merged
merged 2 commits into from Nov 30, 2015

Conversation

bangerth
Copy link
Member

This fixes #1397. In relation to #1198.

* presets the #interface_constraints matrix to have dimension zero. Changing
* this behaviour in derived classes is generally not a reasonable idea and
* you risk getting into trouble.
* In in one space dimension (i.e., for <code>dim==1</code> and any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In in" -> "In"

@kronbichler
Copy link
Member

When you are done with the language issues, merge yourself. The other more general question can be made into an issue if we have more data supporting it or rebutted if too much work.

@bangerth
Copy link
Member Author

Thanks, @kronbichler , for your patience reading through this. This was the kind of patch one pushes just as one has to leave. I though it should be good enough, but in hindsight it clearly wasn't ready :-(

I fixed all of the points you mention. Thanks for the review!

bangerth added a commit that referenced this pull request Nov 30, 2015
Finish rewriting the documentation of class FiniteElement.
@bangerth bangerth merged commit f0c7c4f into dealii:master Nov 30, 2015
@bangerth bangerth deleted the document-fe-2 branch November 30, 2015 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEValues cleanup: Go through the documentation of FiniteElement
2 participants