Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge code from MappingQGeneric and MappingManifold #2478

Open
bangerth opened this issue Apr 7, 2016 · 2 comments
Open

Merge code from MappingQGeneric and MappingManifold #2478

bangerth opened this issue Apr 7, 2016 · 2 comments
Labels
Enhancement Mapping

Comments

@bangerth
Copy link
Member

bangerth commented Apr 7, 2016

Classes MappingQGeneric and MappingManifold (introduced in #2272) share an exact copy of transform_field and similar functions. These could/should be merged.
@bangerth bangerth mentioned this issue Apr 7, 2016
Merged
8 tasks
@bangerth
Copy link
Member Author

bangerth commented Apr 7, 2016

The other functions are called transform_gradients, transform_hessians, etc.

@bangerth
Copy link
Member Author

bangerth commented Apr 7, 2016

A reasonable solution would be, for example, to move the fields in the Mapping*::InternalData classes that these functions access, along with these functions, into an intermediate class, say MappingBase::MappedInternalData or similar.

@tamiko tamiko mentioned this issue Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Mapping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tamiko @bangerth @davydden