Tighten up error messages. #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has long annoyed me that when we print exception messages that were created
via ExcMessage, that the information is really duplicative. Example:
--------------------------------------------------------
An error occurred in line <710> of file <.../step-6.cc> in function
int main()
The violated condition was:
false
The name and call sequence of the exception was:
ExcMessage ("abc" "def")
Additional Information:
abcdef
Stacktrace:
-----------
#0 ./step-6: main
--------------------------------------------------------
Here, the text that comes after 'The name and call sequence...'
is duplicative with what comes after 'Additional Information:'.
This is specifically the case for ExcMessage errors because
there *everything* that constructs the 'Additional information'
will actually be also under 'The name and...' part.
This patch cleans this up by omitting the first of these two
parts if the error message was created via ExcMessage.
|
I like it! Did you check that no test breaks because of this change? |
|
Yes, I verified that the middle part of the message is gone and that no tests fail. |
|
Could be assumed to be part of #610. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has long annoyed me that when we print exception messages that were created
via ExcMessage, that the information is really duplicative. Example:
An error occurred in line <710> of file <.../step-6.cc> in function
int main()
The violated condition was:
false
The name and call sequence of the exception was:
ExcMessage ("abc" "def")
Additional Information:
abcdef
Stacktrace:
#0 ./step-6: main
Here, the text that comes after 'The name and call sequence...'
is duplicative with what comes after 'Additional Information:'.
This is specifically the case for ExcMessage errors because
there everything that constructs the 'Additional information'
will actually be also under 'The name and...' part.
This patch cleans this up by omitting the first of these two
parts if the error message was created via ExcMessage.