Static analysis: dealii-git/source/multigrid/mg_level_global_transfer.cc

[bangerth]

dealii-git/source/multigrid/mg_level_global_transfer.cc	393	warn	V688 The 'copy_indices' local variable possesses the same name as one of the class members, which can result in a confusion.
dealii-git/source/multigrid/mg_level_global_transfer.cc	395	warn	V688 The 'copy_indices_global_mine' local variable possesses the same name as one of the class members, which can result in a confusion.
dealii-git/source/multigrid/mg_level_global_transfer.cc	397	warn	V688 The 'copy_indices_level_mine' local variable possesses the same name as one of the class members, which can result in a confusion.
dealii-git/source/multigrid/mg_level_global_transfer.cc	451	err	V758 The 'global_partitioner' reference becomes invalid when smart pointer returned by a function is destroyed.
dealii-git/source/multigrid/mg_level_global_transfer.cc	453	err	V758 The 'level_partitioner' reference becomes invalid when smart pointer returned by a function is destroyed.
dealii-git/source/multigrid/mg_level_global_transfer.cc	61	warn	V730 Not all members of a class are initialized inside the constructor. Consider inspecting: level, global_dof_index, level_dof_index.

We should address these warnings and errors from the static analysis tool PVS. In response to #3342.

[bangerth]

The two warnings about global_partitioner and level_partitioner are not strictly wrong, but I'm going to choose not to fix them: we ask some long-lived object for a reference to one of its members that happens to be stored through a std::shared_ptr. The warning is that the reference will become stale if someone deletes the object in the middle, but this does not happen in the very narrow scope in which we keep the reference.