Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis: include/deal.II/base/table_handler.h #3531

Closed
bangerth opened this issue Nov 11, 2016 · 3 comments
Closed

Static analysis: include/deal.II/base/table_handler.h #3531

bangerth opened this issue Nov 11, 2016 · 3 comments

Comments

@bangerth
Copy link
Member

bangerth commented Nov 11, 2016

/home/davydden/libs/deal.ii/include/deal.II/base/thread_management.h	2957	warn	V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'destroy' function.

We should address these warnings and errors from the static analysis tool PVS. In response to #3342.

@bangerth bangerth changed the title Static analysis: /home/davydden/libs/deal.ii/include/deal.II/base/table_handler.h Static analysis: include/deal.II/base/table_handler.h Nov 11, 2016
@bangerth bangerth reopened this Nov 11, 2016
@bangerth
Copy link
Member Author

We should address these warnings and errors from the static analysis tool PVS:

include/deal.II/base/table_handler.h    682 err V730 Not all members of a class are initialized inside the constructor. Consider inspecting: cached_value.

In response to #3342.

@bangerth
Copy link
Member Author

Same as #3532 .

@bangerth
Copy link
Member Author

Oh, we ended up with different messages here. This issue should be for the issue in table_handler.h.

But the point is that cached_value is a string, so it has a default constructor and need not be initialized explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant