Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange PETSc and Trilinos headers #4468

Closed
drwells opened this issue Jun 2, 2017 · 2 comments
Closed

Rearrange PETSc and Trilinos headers #4468

drwells opened this issue Jun 2, 2017 · 2 comments

Comments

@drwells
Copy link
Member

drwells commented Jun 2, 2017

We now have the following PETSc and Trilinos headers:

[drwells@archway lac]$ ls petsc_*
petsc_compatibility.h
petsc_full_matrix.h
petsc_matrix_base.h
petsc_matrix_free.h
petsc_parallel_block_sparse_matrix.h
petsc_parallel_block_vector.h
petsc_parallel_sparse_matrix.h
petsc_parallel_vector.h
petsc_precondition.h
petsc_solver.h
petsc_sparse_matrix.h
petsc_vector_base.h
[drwells@archway lac]$ ls trilinos_*
trilinos_block_sparse_matrix.h
trilinos_epetra_communication_pattern.h
trilinos_epetra_vector.h
trilinos_index_access.h
trilinos_linear_operator.h
trilinos_parallel_block_vector.h
trilinos_precondition.h
trilinos_solver.h
trilinos_sparse_matrix.h
trilinos_sparsity_pattern.h
trilinos_vector.h
trilinos_vector_base.h

The odd header here is trilinos_vector.h which contains the declaration of TrilinosWrappers::MPI::Vector. Since we removed the non-parallel vectors, I propose that we remove the parallel prefix (e.g., petsc_parallel_vector.h to just petsc_vector.h) to make things consistent and deprecate the old headers.

@drwells
Copy link
Member Author

drwells commented Jun 2, 2017

I am not sure how to make our own LinearAlgebra vectors fit but I really think we should use a consistent scheme.

@bangerth
Copy link
Member

bangerth commented Jun 2, 2017

I think your suggestion makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants