Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change coefficient type in KellyErrorEstimator::estimate() #5492

Closed
bangerth opened this issue Nov 17, 2017 · 2 comments
Closed

Change coefficient type in KellyErrorEstimator::estimate() #5492

bangerth opened this issue Nov 17, 2017 · 2 comments

Comments

@bangerth
Copy link
Member

#5419 changes the Neumann boundary values provided to KellyErrorEstimator::estimate() to match the type of the solution vector -- in other words, if the solution vector is complex-valued, then you now also need to pass a Function<dim,std::complex<double>> as argument for the Neumann values. This makes sense.

I did not change the coefficient function the KellyErrorEstimator::estimate() functions take. That's because that class is typically meant for elliptic problems where the coefficient would have to be real (we assume that the coefficient is a scalar, and the only Hermitian 1x1 matrix is a real one). But then, the class is also used for other purposes. What do you all think?

@davydden
Copy link
Contributor

i would keep it as-is until we have a need for complex-valued heterogeneity coefficient. Personally, i have not came across such cases.

@bangerth
Copy link
Member Author

bangerth commented Dec 7, 2017

There was no objection to leaving it as is. So let's go with that.

@bangerth bangerth closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants