Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look over clang-format indentation with many specifiers #8437

Closed
kronbichler opened this issue Jul 31, 2019 · 3 comments
Closed

Look over clang-format indentation with many specifiers #8437

kronbichler opened this issue Jul 31, 2019 · 3 comments
Labels
Milestone

Comments

@kronbichler
Copy link
Member

In #8428 we observed that clang-format does sometimes struggle with creating a good indentation when we use many specifiers, sometimes hidden behind the keywords. The result can look e.g.

static constexpr DEAL_II_ALWAYS_INLINE DEAL_II_CUDA_HOST_DEV T
                                                             value(const F &f,
                                                                   typename std::enable_if<

This looks ugly and sometimes even breaks the 80 char line length (as here).

Before the next release we should look this through systematically and find out whether

@kronbichler
Copy link
Member Author

This is not critical and likely nobody is really interested in working on this now, so I'm adjusting the target milestone.

@kronbichler kronbichler modified the milestones: Release 9.2, Release 9.3 Mar 20, 2020
This was referenced Oct 26, 2020
@masterleinad
Copy link
Member

Let's do #11108 after the release.

@peterrum peterrum modified the milestones: Release 9.4, Release 9.5 Apr 22, 2022
@kronbichler
Copy link
Member Author

#11108 has been done and it overall looks better, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants