You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Followup to #8556. I need to write all this down so that we remember how to actually fix it later.
AFAICT, GridReordering::invert_all_cells_of_negative_grid contains a bug where it assumes that the input uses the old-style numbering (i.e., pre 6.0). However, we only call this function immediately before calling Triangulation::create_triangulation_compatibility, which also assumes that the cells use the old-style numbering: i.e., it is called in the middle of a pipeline where we use the old numbering, so it works (in this context) correctly.
I suggest that we deprecate this function and replace it with a new function named GridTools::invert_cells_with_negative_measure that assumes we use the standard numbering. We should fix our GridIn code to actually use the new numbering everywhere so that we can remove all internal calls to create_triangulation_compatibility and then deprecate that function too.
The text was updated successfully, but these errors were encountered:
Followup to #8556. I need to write all this down so that we remember how to actually fix it later.
AFAICT,
GridReordering::invert_all_cells_of_negative_grid
contains a bug where it assumes that the input uses the old-style numbering (i.e., pre 6.0). However, we only call this function immediately before callingTriangulation::create_triangulation_compatibility
, which also assumes that the cells use the old-style numbering: i.e., it is called in the middle of a pipeline where we use the old numbering, so it works (in this context) correctly.I suggest that we deprecate this function and replace it with a new function named
GridTools::invert_cells_with_negative_measure
that assumes we use the standard numbering. We should fix ourGridIn
code to actually use the new numbering everywhere so that we can remove all internal calls tocreate_triangulation_compatibility
and then deprecate that function too.The text was updated successfully, but these errors were encountered: