Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excise remaining compatibility renumberings #8562

Closed
drwells opened this issue Aug 13, 2019 · 0 comments · Fixed by #12049
Closed

Excise remaining compatibility renumberings #8562

drwells opened this issue Aug 13, 2019 · 0 comments · Fixed by #12049
Assignees
Milestone

Comments

@drwells
Copy link
Member

drwells commented Aug 13, 2019

Followup to #8556. I need to write all this down so that we remember how to actually fix it later.

AFAICT, GridReordering::invert_all_cells_of_negative_grid contains a bug where it assumes that the input uses the old-style numbering (i.e., pre 6.0). However, we only call this function immediately before calling Triangulation::create_triangulation_compatibility, which also assumes that the cells use the old-style numbering: i.e., it is called in the middle of a pipeline where we use the old numbering, so it works (in this context) correctly.

I suggest that we deprecate this function and replace it with a new function named GridTools::invert_cells_with_negative_measure that assumes we use the standard numbering. We should fix our GridIn code to actually use the new numbering everywhere so that we can remove all internal calls to create_triangulation_compatibility and then deprecate that function too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant