Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Jacobian gradient before correcting higher derivatives #9682

Open
simonsticko opened this issue Mar 19, 2020 · 5 comments
Open

Check Jacobian gradient before correcting higher derivatives #9682

simonsticko opened this issue Mar 19, 2020 · 5 comments
Labels

Comments

@simonsticko
Copy link
Contributor

Correcting the 2nd and 3rd derivatives of the shape functions with the derivatives of the Jacobian is expensive. #9530 adds a function
higher_derivatives_need_correcting in fe/fe_poly.templates.h
that returns whether the correction terms need to be computed. Currently this function only checks if the mapping is Cartesian, but a more general condition would be to check the value of the jacobian_grads_pushed_forward at the quadrature points. Precisely what condition should be checked is open for discussion.

@bangerth
Copy link
Member

The condition to check is whether the norm of jacobian_grads_pushed_forward is << than the norm of jacobian divided by some length scale (e.g., the diameter of the cell we're on).

@bangerth bangerth added this to the Release 9.2 milestone Mar 19, 2020
@masterleinad
Copy link
Member

I don't think this is crucial for the release and would move the milestone unless there are volunteers to tackle it.

@kronbichler kronbichler modified the milestones: Release 9.2, Release 9.3 May 8, 2020
@peterrum peterrum modified the milestones: Release 9.3, Release 10.0 May 1, 2021
@peterrum
Copy link
Member

@simonsticko How do we want to continue here?

@kronbichler
Copy link
Member

I guess this is not critical, so we can postpone the target milestone (and if we happen to have time for this one we can still work on it).

@kronbichler kronbichler modified the milestones: Release 9.4, Release 9.5 May 9, 2022
@bangerth bangerth modified the milestones: Release 9.5, Release 9.6 Jun 5, 2023
@kronbichler
Copy link
Member

I think we have substantially reduced costs in MappingQ related functions by #15035 and #15125 and I consider this issue addressed. Of course it would be nice to get further progress also for other mappings, but I suggest to remove it from the current target milestone, given how long this has been around unaddressed.

@kronbichler kronbichler removed this from the Release 9.6 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants