New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Jacobian gradient before correcting higher derivatives #9682
Comments
The condition to check is whether the norm of |
I don't think this is crucial for the release and would move the milestone unless there are volunteers to tackle it. |
@simonsticko How do we want to continue here? |
I guess this is not critical, so we can postpone the target milestone (and if we happen to have time for this one we can still work on it). |
I think we have substantially reduced costs in |
Correcting the 2nd and 3rd derivatives of the shape functions with the derivatives of the Jacobian is expensive. #9530 adds a function
higher_derivatives_need_correcting
infe/fe_poly.templates.h
that returns whether the correction terms need to be computed. Currently this function only checks if the mapping is Cartesian, but a more general condition would be to check the value of the
jacobian_grads_pushed_forward
at the quadrature points. Precisely what condition should be checked is open for discussion.The text was updated successfully, but these errors were encountered: