-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for JSON #13
Merged
Merged
Support for JSON #13
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
540a282
initial commit with json extractor hand tested
anthonygarvan d65103d
all tests passing
anthonygarvan 83e4927
fixing snow on travis
anthonygarvan 0f0eef4
linking to textract travis in quick start doc
anthonygarvan 6daa525
readding try-except logic for swallowing bad extensions
anthonygarvan 8b5beb6
added support for lists
anthonygarvan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"hey":"hello world this is some text from a json document", | ||
"should_ignore_this_number": 42, | ||
"should_extract_one_two_three": { | ||
"1": "one", | ||
"2": "two", | ||
"3": "three", | ||
"should_be_abcdef": ["a", "b", "c", ["d","e"], {"dict":"f"}] | ||
}, | ||
"finished": "fine" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import json | ||
|
||
|
||
def extract(filename, **kwargs): | ||
f = open(filename, 'r') | ||
deserialized_json = json.load(f) | ||
return get_text(deserialized_json) | ||
|
||
|
||
def get_text(deserialized_json): | ||
if isinstance(deserialized_json, dict): | ||
result = '' | ||
for key in deserialized_json: | ||
result += get_text(deserialized_json[key]) + ' ' | ||
return result | ||
|
||
if isinstance(deserialized_json, list): | ||
result = '' | ||
for item in deserialized_json: | ||
result += get_text(item) + ' ' | ||
return result | ||
|
||
if isinstance(deserialized_json, basestring): | ||
return deserialized_json | ||
else: | ||
return '' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting way of handling this. Maybe we should rename all of the parser modules to something like
{{ext}}_parser
to avoid conflicts with globally installed packages.We run into this problem in the
docx
andpptx
modules too and we use the utils.non_local_import function to deal with it. While clever, I'm not terribly happy with that implementation and think you've got a better way of handling this. I'll make some changes to how those are incorporated after merging.