Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .xls/xlsx support #42 #55

Merged
merged 9 commits into from Aug 15, 2014
Merged

Conversation

levivm
Copy link
Contributor

@levivm levivm commented Aug 14, 2014

Added support for .xls and .xlsx format, using xlrd python lib.

@nicokoch
Copy link
Contributor

Two things I came across reviewing your code:

  • The comment in your parser describes the method as extracting .docx files :-P
  • The code for .xls and .xlsx seem to be very similar (or exactly the same?). Instead of copying the code, it would be a lot cleaner to reuse it (an example of how to do this can be seen in the .jpg, .gif and .png parsers).

So nothing critical, just some suggestions.

@deanmalmgren
Copy link
Owner

I just took a quick look, too. Thanks for putting this together; looks great! I made some comments above, mostly building off @kokxx's suggestions and accounting for changes I plan to merge in #39, probably sometime next week.

I was a little confused about all the changing of the functional test checksums but I see that all of the non-excel checksums were ultimately changed to the same values in the master branch. Apologies if you received an email about a comment I made; I ultimately figured it out and deleted the comment on github :)

@deanmalmgren deanmalmgren merged commit fe02796 into deanmalmgren:master Aug 15, 2014
deanmalmgren pushed a commit that referenced this pull request Aug 15, 2014
@deanmalmgren
Copy link
Owner

Excellent; thanks @levivm! This is all merged in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants