Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowId is undefined - Spaces is losing all data #14

Closed
Martin-Pitt opened this issue Nov 2, 2018 · 9 comments
Closed

windowId is undefined - Spaces is losing all data #14

Martin-Pitt opened this issue Nov 2, 2018 · 9 comments

Comments

@Martin-Pitt
Copy link

This has been happening a few times this month now where Spaces will completely erase all data.

image

All the values turn to null in the IndexedDB sessions:

image

This happened with the version in the Chrome store as well, then I moved over to this GitHub version hoping it would solve my issues.

I have lost over 45 sessions with hundreds of pages in the store version and two of them in this github version (hence two rows in the IDB screenshot). This has been really devastating.

I'm on Google Chrome 72.0.3599.0 (Official Build) canary (64-bit)

@Martin-Pitt
Copy link
Author

Martin-Pitt commented Nov 2, 2018

In the support section of the webstore version there is also a comment by another user who lost their work on 10th October – which I think is when I started losing my data as well.

Note that ALL saved spaces were erased, I only keep one or two open.

@Thovthe
Copy link
Contributor

Thovthe commented Nov 3, 2018

I know this doesn't help you now and is sub optimal but:
Since spaces is not yet super stable I back mine up outside it pretty regularly.
(And who knows if it will ever be, the browser companies have broke extension compatibility many times before.)

The workflow looks like this:

  1. Change Chrome's download directory to a new one called 'Tabs_Backup_DATE'
  2. Click through and export each space.
  3. Change the download directory back.

@themightychris
Copy link

themightychris commented Nov 3, 2018 via email

@Martin-Pitt
Copy link
Author

@themightychris "Backup all spaces" exports a truncated JSON file that does not parse correctly.

Exporting each space individually with the top-right download option does work though at least, but with a lot of spaces can be difficult to do repetitively.

Have been using Spaces again more recently now and haven't had a failure for some time now but still scared to rely on it as much as I used to.

@deanoemcke
Copy link
Owner

@Martin-Pitt The "Backup all spaces" bug should be fixed now (it no longer truncates the JSON file). Would you be able to confirm this for me?

@Martin-Pitt
Copy link
Author

Martin-Pitt commented Jan 22, 2020

@deanoemcke, yep the backup all spaces bug is fixed! Well, at least before this new issue:

A new bug is happening on Canary however, newly spaces saved across sessions seem to be now showing up as 'Unnamed window' that I can't select in the manager window. I've got three of these. I can see that the "sessionId" increments to the last numbers from the URL in the manager (57, 58, and 59).

I suspect it is because Canary has a new feature related to grouping tabs.
image

I've not used the grouping tabs feature except for a quick trial run. But I suspect that changes under the hood mean that Spaces might not be acting a bit funny. I'm making sure to backup things, and that functionality is working all right now at least.

@Martin-Pitt
Copy link
Author

Martin-Pitt commented Jan 22, 2020

I'm getting the following stack trace:
image

Looks like I have rogue tab entries stored now that are causing errors:
image

@Martin-Pitt
Copy link
Author

The latest version 1.1.2 has filtered out the bad undefined/spaces, preventing errors from stacking up and it breaking.

Created a new space, and restarted chrome, seems to have remembered it this time.

@jonathancross
Copy link

@Martin-Pitt Is this issue resolved then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants